Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Smithy dependencies #652

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Add missing Smithy dependencies #652

merged 1 commit into from
Mar 22, 2024

Conversation

trstephen-amazon
Copy link
Contributor

Resubmission of #651 while we debug creds retrieval.

Description of changes: Added explicit dependencies to @smithy/smithy-client and @smithy/node-http-handler, as they were not declared, which causes phantom dependency issues in non-hoisting package managers such as pnpm (with hoisting disabled, as used by Bazel, for example). I've chosen the same version qualifier/selector that is used in transitive dependencies to avoid any unexpected package version variations. This should not affect any of this package's consumers.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Resubmission of #651 while we debug creds retrieval.

Co-authored-by: gscalise <[email protected]>
@trstephen-amazon trstephen-amazon marked this pull request as ready for review March 21, 2024 22:34
@trstephen-amazon trstephen-amazon merged commit 4f0ce95 into master Mar 22, 2024
11 checks passed
@trstephen-amazon trstephen-amazon deleted the trs/add-smithy branch March 22, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants