Add missing Smithy dependencies #651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trstephen-amazon
approved these changes
Mar 20, 2024
trstephen-amazon
added a commit
that referenced
this pull request
Mar 21, 2024
Resubmission of #651 while we debug creds retrieval. Co-authored-by: gscalise <[email protected]>
trstephen-amazon
added a commit
that referenced
this pull request
Mar 22, 2024
Resubmission of #651 while we debug creds retrieval. Co-authored-by: gscalise <[email protected]>
|
Changes implemented in #652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Added explicit dependencies to
@smithy/smithy-clientand@smithy/node-http-handler, as they were not declared, which causes phantom dependency issues in non-hoisting package managers such aspnpm(with hoisting disabled, as used by Bazel, for example). I've chosen the same version qualifier/selector that is used in transitive dependencies to avoid any unexpected package version variations. This should not affect any of this package's consumers.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.