Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 2.163.1 #31847

Merged
merged 2 commits into from
Oct 22, 2024
Merged

chore(release): 2.163.1 #31847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aa63d1
fix: 'Need to perform AWS calls for account' when doing cross-account…
rix0rrr Oct 22, 2024
11275fa
chore(release): 2.163.1
mrgrain Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.v2.alpha.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

## [2.163.1-alpha.0](https://github.com/aws/aws-cdk/compare/v2.163.0-alpha.0...v2.163.1-alpha.0) (2024-10-22)

## [2.163.0-alpha.0](https://github.com/aws/aws-cdk/compare/v2.162.1-alpha.0...v2.163.0-alpha.0) (2024-10-21)


Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.v2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

## [2.163.1](https://github.com/aws/aws-cdk/compare/v2.163.0...v2.163.1) (2024-10-22)


### Bug Fixes

* 'Need to perform AWS calls for account' when doing cross-account deployments ([#31846](https://github.com/aws/aws-cdk/issues/31846)) ([5aa63d1](https://github.com/aws/aws-cdk/commit/5aa63d136294a42df2f65a3705655eb3c108fc2c)), closes [#31845](https://github.com/aws/aws-cdk/issues/31845)

## [2.163.0](https://github.com/aws/aws-cdk/compare/v2.162.1...v2.163.0) (2024-10-21)


Expand Down
8 changes: 4 additions & 4 deletions packages/aws-cdk/lib/api/deployments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@ export class Deployments {
const { manifest, stackEnv } = await this.prepareAndValidateAssets(asset, options);
await publishAssets(manifest, this.sdkProvider, stackEnv, {
...options.publishOptions,
allowCrossAccount: await this.allowCrossAccountAssetPublishingForEnv(stackEnv),
allowCrossAccount: await this.allowCrossAccountAssetPublishingForEnv(options.stack),
});
}

Expand Down Expand Up @@ -852,15 +852,15 @@ export class Deployments {
// No need to validate anymore, we already did that during build
const publisher = this.cachedPublisher(assetManifest, stackEnv, options.stackName);
// eslint-disable-next-line no-console
await publisher.publishEntry(asset, { allowCrossAccount: await this.allowCrossAccountAssetPublishingForEnv(stackEnv) });
await publisher.publishEntry(asset, { allowCrossAccount: await this.allowCrossAccountAssetPublishingForEnv(options.stack) });
if (publisher.hasFailures) {
throw new Error(`Failed to publish asset ${asset.id}`);
}
}

private async allowCrossAccountAssetPublishingForEnv(env: cxapi.Environment): Promise<boolean> {
private async allowCrossAccountAssetPublishingForEnv(stack: cxapi.CloudFormationStackArtifact): Promise<boolean> {
if (this._allowCrossAccountAssetPublishing === undefined) {
const sdk = (await this.cachedSdkForEnvironment(env, Mode.ForReading)).sdk;
const { stackSdk: sdk } = await this.prepareSdkFor(stack, undefined, Mode.ForReading);
this._allowCrossAccountAssetPublishing = await determineAllowCrossAccountAssetPublishing(sdk, this.props.toolkitStackName);
}
return this._allowCrossAccountAssetPublishing;
Expand Down
4 changes: 2 additions & 2 deletions version.v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"version": "2.163.0",
"alphaVersion": "2.163.0-alpha.0"
"version": "2.163.1",
"alphaVersion": "2.163.1-alpha.0"
}
Loading