Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): 2.163.1 #31847

Merged
merged 2 commits into from
Oct 22, 2024
Merged

chore(release): 2.163.1 #31847

merged 2 commits into from
Oct 22, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Oct 22, 2024

See CHANGELOG

rix0rrr and others added 2 commits October 22, 2024 16:10
@rix0rrr @mrgrain
fix: 'Need to perform AWS calls for account' when doing cross-account…
5aa63d1 
… deployments (#31846)

Fixes #31845  

Manually verified that cross-account access is possible again. Will follow up with a PR for more tests. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@mrgrain
chore(release): 2.163.1
11275fa
@mrgrain mrgrain added the pr/no-squash This PR should be merged instead of squash-merging it label Oct 22, 2024
@github-actions github-actions bot added the p2 label Oct 22, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 22, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 22, 2024 15:16
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Oct 22, 2024
@mrgrain mrgrain added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Oct 22, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 22, 2024 15:17

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 11275fa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 22, 2024

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c14a1ff into v2-release Oct 22, 2024
32 of 35 checks passed
@mergify mergify bot deleted the patch/v2.163.1 branch October 22, 2024 15:45
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HBobertz HBobertz HBobertz approved these changes

@rix0rrr rix0rrr rix0rrr approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr/no-squash This PR should be merged instead of squash-merging it pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrgrain @aws-cdk-automation @rix0rrr @HBobertz