Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producer jenkins #64

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Producer jenkins #64

merged 1 commit into from
Oct 15, 2020

Conversation

disa6302
Copy link
Contributor

@disa6302 disa6302 commented Oct 1, 2020

Issue #, if available:
#68, #106

Description of changes:

  • Jenkins pipeline for producer SDK

Todo:

  • Add design document

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@disa6302 disa6302 marked this pull request as draft October 1, 2020 22:12
@disa6302 disa6302 force-pushed the producer branch 13 times, most recently from a47e088 to 27d9bde Compare October 7, 2020 18:42
@disa6302 disa6302 force-pushed the producer branch 16 times, most recently from f1052ae to 471cdba Compare October 12, 2020 20:40
Copy link
Contributor

@lherman-cs lherman-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment about the CI integration. Also, could you squash your commit into a single commit?

@disa6302
Copy link
Contributor Author

Small comment about the CI integration. Also, could you squash your commit into a single commit?

Will do when I am about to merge.

@disa6302 disa6302 force-pushed the producer branch 4 times, most recently from aaca5dc to 714366d Compare October 15, 2020 17:30
Copy link
Contributor

@lherman-cs lherman-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for the CI to pass.

@lherman-cs lherman-cs merged commit cb537b8 into master Oct 15, 2020
@lherman-cs lherman-cs deleted the producer branch October 15, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants