Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Makefile instead to add consumer to our CI #106

Open
disa6302 opened this issue Oct 15, 2020 · 3 comments
Open

Use Makefile instead to add consumer to our CI #106

disa6302 opened this issue Oct 15, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@disa6302
Copy link
Contributor

I'd highly recommend to use Makefile instead so we can even add this to our CI.

To add this to the CI, you just need to create a Makefile that has "test" as the target, and add the directory path to the target in .travis.yaml below:

- env: TARGET=webrtc-c/canary

It's definitely not the best test, but it can add some sanity check at least.

Originally posted by @lherman-cs in #64 (comment)

@disa6302 disa6302 changed the title I'd highly recommend to use Makefile instead so we can even add this to our CI. Use Makefile instead to add consumer to our CI Oct 15, 2020
@disa6302
Copy link
Contributor Author

The makefile works on systems. However, travis has a log limit https://docs.travis-ci.com/user/common-build-problems/#log-length-exceeded, which causes a problem since mvn package generates a lot of logs. This error can be solved using mvn package -q which will set verbosity to error. However, due to no logs for prolonged period, travis build fails with the following error: Build times out because no output was received .

We need to look into the best way to add the consumer-java to .travis.yml.

@lherman-cs
Copy link
Contributor

It's going to be very silly to do this, but maybe we can add something like,

while 1; do echo "Processing" && sleep 1; done &

@disa6302
Copy link
Contributor Author

Yes. I was thinking something along the same lines. But thought of this as a last ditch effort after exhausting all other options :/

@MushMal MushMal added the enhancement New feature or request label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants