Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi_object_tracker): integrate odometry and transform processes #9912

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jan 14, 2025

Description

Define a class Odometry to integrate odometry and transform related processes.

This PR do not change the main logic. However, the timing to require the transform has been changed.

Related links

Parent Issue:

  • Link

How was this PR tested?

TIER IV INTERNAL

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@technolojin technolojin self-assigned this Jan 14, 2025
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 14, 2025
Copy link

github-actions bot commented Jan 14, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin changed the title feat(multi_object_tracker): odometry and transform process by class feat(multi_object_tracker): integrate odometry and transform processes Jan 14, 2025
@technolojin technolojin force-pushed the feat/multi-obj-track/odometery-manager branch from c6e980a to 0fe20db Compare January 14, 2025 09:28
refactor: Transform objects to world coordinate in Odometry class

refactor: Update Odometry class to get transform from tf with source frame ID

feat: Update Odometry class to get transform from tf with source frame ID

fix: move necessare tr2 header
Signed-off-by: Taekjin LEE <[email protected]>
@technolojin technolojin force-pushed the feat/multi-obj-track/odometery-manager branch from 0fe20db to 53a696a Compare January 14, 2025 09:43
@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 89 lines in your changes missing coverage. Please review.

Project coverage is 29.43%. Comparing base (9c0e183) to head (b0dedf2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ion/autoware_multi_object_tracker/lib/odometry.cpp 0.00% 69 Missing ⚠️
...lti_object_tracker/src/processor/input_manager.cpp 0.00% 11 Missing ⚠️
...i_object_tracker/src/multi_object_tracker_node.cpp 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9912      +/-   ##
==========================================
- Coverage   29.44%   29.43%   -0.01%     
==========================================
  Files        1444     1445       +1     
  Lines      108611   108645      +34     
  Branches    42421    42430       +9     
==========================================
  Hits        31982    31982              
- Misses      73542    73576      +34     
  Partials     3087     3087              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 29.46% <ø> (+0.01%) ⬆️ Carriedforward from 53a696a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin marked this pull request as ready for review January 14, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant