Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_collision_checker): move to autoware namespace #9047

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

move to autoware namespace

168a0fa
Select commit
Loading
Failed to load commit list.
Open

refactor(obstacle_collision_checker): move to autoware namespace #9047

move to autoware namespace
168a0fa
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Oct 7, 2024 in 35s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.05 (9.69 -> 9.74)

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Bumpy Road Ahead debug.cpp: create_marker_array

✅ Improving Code Health:

  • Bumpy Road Ahead obstacle_collision_checker_node.cpp: ObstacleCollisionCheckerNode::create_marker_array

Annotations

Check warning on line 88 in control/autoware_obstacle_collision_checker/src/debug.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

create_marker_array has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check notice on line 261 in control/autoware_obstacle_collision_checker/src/obstacle_collision_checker_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ No longer an issue: Bumpy Road Ahead

ObstacleCollisionCheckerNode::create_marker_array is no longer above the threshold for logical blocks with deeply nested code