feat(build-and-test-differential): modify clang-tidy to run only on specified packages #9016
+239
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Y.Hisaki <[email protected]>
github-actions
bot
added
the
type:ci
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
yhisaki
requested review from
kosuke55,
kyoichi-sugahara,
mkuri,
zusizusi,
taikitanaka3,
TakaHoribe and
takayuki5168
as code owners
github-actions
bot
added
the
component:vehicle
yhisaki
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9016 +/- ##
==========================================
- Coverage 26.68% 26.67% -0.01%
==========================================
Files 1296 1297 +1
Lines 95679 95704 +25
Branches 39078 39079 +1
==========================================
Hits 25530 25530
- Misses 67494 67519 +25
Partials 2655 2655
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Y.Hisaki <[email protected]>
…dy-specific-packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, clang-tidy checks are being executed but are not required and are being ignored. However, clang-tidy outputs important warnings that should not be disregarded.
This PR aims to gradually make clang-tidy checks required on a package-by-package basis. With this PR, the following process related to clang-tidy will be executed on GitHub Actions:
clang-tidy-required-package.yamland those retrieved in step 1.By progressively adding clang-tidy-compliant packages to
clang-tidy-required-package.yaml, we can achieve gradual improvement in code quality.This PR is related to this PR.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.