Minor installation suggestion

[markcharder]

Dear developers,
errlog.txt

I am not sure if this program is still being maintained but it might be good to enforce -std=c++11 in the make file, e.g.

CFLAGS = -O3 -std=c++11

Compilation fails with gcc 12.2.0 (c++17) due to namespace ambiguity for the type data. See attached make error log, for example.

I love the program, and LDhot, by the way. I am looking forward to discovering some new things about recombination in the species I work on!

All the best,
Mark

[auton1]

Thank you - it is a good suggestion. However, it would (I think) break backwards compatibility with older versions. I’ll think about it - maybe there is a way to have the best of both worlds. Glad you find the program useful! Adam Auton

…

On Sun, Jan 14, 2024 at 17:46 Mark Derbyshire ***@***.***> wrote: Dear developers, errlog.txt <https://github.com/auton1/LDhat/files/13933940/errlog.txt> I am not sure if this program is still being maintained but it might be good to enforce -std=c++11 in the make file, e.g. CFLAGS = -O3 -std=c++11 Compilation fails with gcc 12.2.0 (c++17) due to namespace ambiguity for the type data. See attached make error log, for example. I love the program, and LDhot, by the way. I am looking forward to discovering some new things about recombination in the species I work on! All the best, Mark — Reply to this email directly, view it on GitHub <#27>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABEVMY63PNQ4XBZ44CUHLS3YOSDARAVCNFSM6AAAAABB2RHHBOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4DCMBZGY2DIMA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[Gullumluvl]

Hi!

to be fully explicit, I managed to compile LDhat with the following flags for GCC 4.8.5 and GCC 14.2:

make CC='gcc -std=c89' CPP='g++ -std=c++11'

Otherwise starting from -std=c99 I was getting the error:

convert.c:11:1: error: return type defaults to ‘int’ [-Wimplicit-int]
   11 | main (int argc, char *argv[]) {
      | ^~~~

Best,