Skip to content

Commit

Permalink
fix(subscription): fix subscription disposal
Browse files Browse the repository at this point in the history
uses new subscription objects dispose method to free up the existing
event aggregator subscription

fixes issue #24
  • Loading branch information
zewa666 committed Oct 15, 2015
1 parent 7a078d3 commit b9896be
Show file tree
Hide file tree
Showing 11 changed files with 19 additions and 10 deletions.
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "aurelia-i18n",
"version": "0.2.5",
"version": "0.2.6",
"description": "A plugin that provides i18n support.",
"keywords": [
"aurelia",
Expand Down
2 changes: 1 addition & 1 deletion dist/amd/base-i18n.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ define(['exports', './i18n', 'aurelia-event-aggregator'], function (exports, _i1
}, {
key: 'detached',
value: function detached() {
this.__i18nDisposer();
this.__i18nDisposer.dispose();
}
}]);

Expand Down
2 changes: 1 addition & 1 deletion dist/amd/t.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ define(['exports', './i18n', 'aurelia-event-aggregator', 'aurelia-templating', '
}, {
key: 'unbind',
value: function unbind() {
this.subscription();
this.subscription.dispose();
}
}]);

Expand Down
2 changes: 1 addition & 1 deletion dist/commonjs/base-i18n.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ var BaseI18N = (function () {
}, {
key: 'detached',
value: function detached() {
this.__i18nDisposer();
this.__i18nDisposer.dispose();
}
}]);

Expand Down
2 changes: 1 addition & 1 deletion dist/commonjs/t.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ var TCustomAttribute = (function () {
}, {
key: 'unbind',
value: function unbind() {
this.subscription();
this.subscription.dispose();
}
}]);

Expand Down
2 changes: 1 addition & 1 deletion dist/es6/base-i18n.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ export class BaseI18N {
}

detached() {
this.__i18nDisposer();
this.__i18nDisposer.dispose();
}
}
2 changes: 1 addition & 1 deletion dist/es6/t.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,6 @@ export class TCustomAttribute {
}

unbind() {
this.subscription();
this.subscription.dispose();
}
}
2 changes: 1 addition & 1 deletion dist/system/base-i18n.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ System.register(['./i18n', 'aurelia-event-aggregator'], function (_export) {
}, {
key: 'detached',
value: function detached() {
this.__i18nDisposer();
this.__i18nDisposer.dispose();
}
}]);

Expand Down
2 changes: 1 addition & 1 deletion dist/system/t.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ System.register(['./i18n', 'aurelia-event-aggregator', 'aurelia-templating', './
}, {
key: 'unbind',
value: function unbind() {
this.subscription();
this.subscription.dispose();
}
}]);

Expand Down
9 changes: 9 additions & 0 deletions doc/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
### 0.2.6 (2015-10-15)


#### Bug Fixes

* **event-aggregator:** dispose ea subscriptions correctly ([c387adbf](http://github.com/aurelia/i18n/commit/c387adbf4d41957bb06f64104c1073bca4507c9a))
* **tests:** fix unit tests ([203a3ce6](http://github.com/aurelia/i18n/commit/203a3ce63db9f3c912b732d9473e17ce001e3726))


### 0.2.5 (2015-10-14)


Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "aurelia-i18n",
"version": "0.2.5",
"version": "0.2.6",
"description": "A plugin that provides i18n support.",
"keywords": [
"aurelia",
Expand Down

0 comments on commit b9896be

Please sign in to comment.