Skip to content

Commit

Permalink
Merge branch 'JeroenVinke-fix-ea-dispose'
Browse files Browse the repository at this point in the history
  • Loading branch information
zewa666 committed Oct 15, 2015
2 parents 203a3ce + c387adb commit 7a078d3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/base-i18n.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ export class BaseI18N {
}

detached() {
this.__i18nDisposer();
this.__i18nDisposer.dispose();
}
}
2 changes: 1 addition & 1 deletion src/t.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,6 @@ export class TCustomAttribute {
}

unbind() {
this.subscription();
this.subscription.dispose();
}
}
2 changes: 1 addition & 1 deletion test/unit/i18n.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ describe('testing i18n translations', () => {

it('should trigger an event when switching locales', (done) => {
var subscription = sut.ea.subscribe('i18n:locale:changed', (payload) => {
subscription();
subscription.dispose();

expect(payload.oldValue).toBe('en');
expect(payload.newValue).toBe('de');
Expand Down

0 comments on commit 7a078d3

Please sign in to comment.