Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from buf's remote generation alpha #487

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Migrate from buf's remote generation alpha #487

merged 8 commits into from
Aug 30, 2023

Conversation

dmah42
Copy link
Contributor

@dmah42 dmah42 commented Aug 7, 2023

more build issues... still hacking away

@dmah42
Copy link
Contributor Author

dmah42 commented Aug 23, 2023

check deny and check docs are timeouts. so i think this is ready to go.

@dmah42 dmah42 marked this pull request as ready for review August 23, 2023 12:52
@dmah42
Copy link
Contributor Author

dmah42 commented Aug 23, 2023

check deny and check docs are timeouts. so i think this is ready to go.

timeouts resolved by extending them. check deny is still freaking out but i'm not sure how big a deal that is :)

@dmah42
Copy link
Contributor Author

dmah42 commented Aug 23, 2023

seems like somehow youki/libcgroups lost its LICENSE file between v0.0.4 and v0.0.5...

Copy link
Contributor

@future-highway future-highway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build, install and run aurae and auraescript (cells.ts example) successfully.

Also looked at the check deny run and agree that the errors don't look like a big deal.

@@ -28,4 +28,6 @@
* *
\* -------------------------------------------------------------------------- */

use deno_core::Op;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: preferably this would be generated by the macro

@dmah42 dmah42 changed the title [WIP] Migrate from buf's remote generation alpha Migrate from buf's remote generation alpha Aug 30, 2023
@dmah42 dmah42 merged commit f282652 into main Aug 30, 2023
9 of 10 checks passed
@dmah42 dmah42 deleted the buf_migration branch August 30, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants