Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buf update breaks many things #488

Closed
dmah42 opened this issue Aug 7, 2023 · 3 comments
Closed

buf update breaks many things #488

dmah42 opened this issue Aug 7, 2023 · 3 comments

Comments

@dmah42
Copy link
Contributor

dmah42 commented Aug 7, 2023

buf have changed the way their remote plugins work: https://buf.build/docs/migration-guides/migrate-remote-generation-alpha/

old versions of buf cannot download plugins (404) while new versions of buf cannot find plugins because they've moved.

the latter is somewhat solvable (WIP: #487) but the former isn't. things we need:

  1. ensure a minimum version of buf (1.25.0 seems to work)
  2. update all the plugin references in buf.gen.yaml (Migrate from buf's remote generation alpha #487)
@dmah42
Copy link
Contributor Author

dmah42 commented Aug 8, 2023

the newer plugin versions need tonic (and maybe other) updates in Cargo.toml. working on it.

@dmah42
Copy link
Contributor Author

dmah42 commented Aug 8, 2023

as part of 1 above, i added an explicit version check to the Makefile. this also means updating the docker images. i'm not completely happy about having a fixed version, but if buf is going to make breaking changes with minor version releases (and no config version bump) then i don't see an alternative to keep our builds reproducible.

@dmah42
Copy link
Contributor Author

dmah42 commented Oct 3, 2023

i think this is now resolved

@dmah42 dmah42 closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant