Adds the full path to the launch testing stdin #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Voldivh <[email protected]>
clalancette
requested changes
Jun 6, 2023
| @@ -27,22 +27,22 @@ requirements: | |||
| checks: | |||
| - name: Test `hello_world_launch_test.py` | |||
| try: | |||
| - stdin: launch_test test/launch_testing/examples/hello_world_launch_test.py | |||
| - stdin: launch_test /opt/ros/iron/share/launch_testing/examples/hello_world_launch_test.py | |||
There was a problem hiding this comment.
The problem with this is that this is only correct when you are running the tests from Debians. It is not correct for the binaries, or when building from source, or when running on Windows. I'm honestly not sure what to do here; it is a tricky one to describe across all of the platforms.
There was a problem hiding this comment.
I did notice exactly that. However, I thought this test case was only being created for debians (at least those are the only ones that appeared when I searched on all the issues).
There was a problem hiding this comment.
If you look at the closed ones as well (https://github.com/osrf/ros2_test_cases/issues?page=1&q=is%3Aissue+Launch+testing+is%3Aclosed), you'll see tests for Windows, from source, and from binary as well.
There was a problem hiding this comment.
Oh I see what you mean for Windows. Then wouldn't it makes sense to kinda leave it as it is? Perhaps add a little more instructions on what path to add on the command, e.g. launch_test <path_to_share_folder>/launch_testing/examples/hello_world_launch_test.py or something like that.
19 tasks
Signed-off-by: Voldivh <[email protected]>
Signed-off-by: Voldivh <[email protected]>
clalancette
approved these changes
Jun 14, 2023
Yadunund
pushed a commit
that referenced
this pull request
Jun 20, 2023
* Adds the full path to the launch testing stdin * Adds instructions to clone the repository Signed-off-by: Voldivh <[email protected]>
Yadunund
added a commit
that referenced
this pull request
Jul 13, 2023
* move humble requirements to root Signed-off-by: Yadunund <[email protected]> * Update tier 3 os labels and remove source from jammy Signed-off-by: Yadunund <[email protected]> * Tmp fix for redirected links in sitemap that cause duplicate requirements Signed-off-by: Yadunund <[email protected]> * Added an expectation for param delete Signed-off-by: Yadunund <[email protected]> * Fix prompt for service find Signed-off-by: Yadunund <[email protected]> * Update bag info with mcap Signed-off-by: Yadunund <[email protected]> * Added details for component cli tests Signed-off-by: Yadunund <[email protected]> * Add checks for ros1_bridge Signed-off-by: Yadunund <[email protected]> * Added tests for service introspection Signed-off-by: Yadunund <[email protected]> * Add check for asunc_param_client Signed-off-by: Yadunund <[email protected]> * Fix duplicate py checks Signed-off-by: Yadunund <[email protected]> * Add DISTRO_LABEL constant Signed-off-by: Yadunund <[email protected]> * Use DISTRO const to retrieve docs Signed-off-by: Yadunund <[email protected]> * Change the names of launch files to be _launch.py (#347) This matches the current best practice, which we updated in Iron. Signed-off-by: Chris Lalancette <[email protected]> * Update the service executables demon_nodes_py test to use async. (#348) There is no '_sync' version, so this must have been a typo for the '_async' version, which does exist. Signed-off-by: Chris Lalancette <[email protected]> * Add the holonomic parameter to turtlesim tests. (#350) Signed-off-by: Chris Lalancette <[email protected]> * remove extra slash to output correct command (#353) Signed-off-by: Chen Lihui <[email protected]> * fix input (#352) Signed-off-by: Yadunund <[email protected]> * Add linux label to realtime tests (#351) Signed-off-by: Yadunund <[email protected]> * tag linux (#357) Signed-off-by: Yadunund <[email protected]> * Fix up the multicast test to have a try and expect section. (#355) Signed-off-by: Chris Lalancette <[email protected]> * Add in a missing component container name in a test. (#354) Signed-off-by: Chris Lalancette <[email protected]> * Specify frame ids for static transform publisher (#358) Signed-off-by: Yadunund <[email protected]> * Replace executables with link to demos readme (#365) * Replace executables with link to demos readme Signed-off-by: Yadunund <[email protected]> * address feedback Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> * Change references to humble -> iron (#370) Signed-off-by: Chris Lalancette <[email protected]> * Modifies the console input to test out rqt (#374) Signed-off-by: Voldivh <[email protected]> * Adds the label to only test in linux gazebo_ros_pkgs (#392) Signed-off-by: Voldivh <[email protected]> * Removes test cases for Windows (#394) Signed-off-by: Voldivh <[email protected]> * Adds a clearer description for the idl message generation (#390) * Adds a clearer description of the test Signed-off-by: Voldivh <[email protected]> * Replace executables with link to demos readme (#395) * Replace executables with link to demos readme Signed-off-by: Voldivh <[email protected]> * Adds the full path to the launch testing stdin (#393) * Adds the full path to the launch testing stdin * Adds instructions to clone the repository Signed-off-by: Voldivh <[email protected]> * Filter redirects in docs.ros.org sitemap (#405) * Ignore redirects Signed-off-by: Yadunund <[email protected]> * Moved iron requirements to ros2_test_cases Signed-off-by: Yadunund <[email protected]> * Restore garden backup Signed-off-by: Yadunund <[email protected]> * Parse YAML_DISTRO_LABEL Signed-off-by: Yadunund <[email protected]> * Update readme and ci Signed-off-by: Yadunund <[email protected]> * Format Signed-off-by: Yadunund <[email protected]> * Make YATM_DISTRO_LABEL a required param Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Signed-off-by: Chen Lihui <[email protected]> Signed-off-by: Voldivh <[email protected]> Co-authored-by: Yadunund <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Chen Lihui <[email protected]> Co-authored-by: Eloy Briceno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an item from #366 according to this discussion.