Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double patch bump #6

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Avoid double patch bump #6

merged 6 commits into from
Jun 14, 2024

Commits on Jun 14, 2024

  1. Reproduce the double patch bump 

    Repro atlassian-labs/db-replica#77
    @dagguh
    dagguh committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    32a5808 View commit details
    Browse the repository at this point in the history

  2. Show how to avoid the double patch bump 

    The `release` task also bumps, a patch one by default.
So just don't use `markNextVersion` within the release process.
It's for manually marking a version for the future.

Show how to avoid atlassian-labs/db-replica#77
    @dagguh
    dagguh committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    495121f View commit details
    Browse the repository at this point in the history

  3. Avoid deprecated gradle-build-action

    @dagguh
    dagguh committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2f38a4a View commit details
    Browse the repository at this point in the history

  4. Enable Build Scans

    @dagguh
    dagguh committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5943a87 View commit details
    Browse the repository at this point in the history

  5. Clean up .m2 before testing it 

    Now the `PublishTest` reproduces locally:
```
java.lang.AssertionError:
Expecting file:
  </Users/mkwidzinski/.m2/repository/com/atlassian/performance/tools/publish-test/0.3.0-SNAPSHOT/publish-test-0.3.0-SNAPSHOT.pom>
to exist.
```

It might look sketchy that we're mutating `~/.m2` in tests.
I thought about publishing to a custom isolated repo.
There are [`flatDir` repos], but they work differently:
> This type of repository does not support any meta-data formats like Ivy XML or Maven POM files.

POM generation is a crucial part of publication, so that would make the test lose too much value.

[`flatDir` repos]: https://docs.gradle.org/7.6.2/userguide/declaring_repositories.html#sub:flat_dir_resolver
    @dagguh
    dagguh committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    919e323 View commit details
    Browse the repository at this point in the history

  6. Fix the expected version in PublishTest 

    We had to change the release tags for double-bump repro in 32a5808
    @dagguh
    dagguh committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5d9a6f0 View commit details
    Browse the repository at this point in the history