Avoid double patch bump #6
Conversation
|
Yes, the tests show:
PS. the CI is red (twice), but locally it's full green. Will take a look tomorrow. |
The `release` task also bumps, a patch one by default. So just don't use `markNextVersion` within the release process. It's for manually marking a version for the future. Show how to avoid atlassian-labs/db-replica#77
dagguh
force-pushed
the
avoid-double-patch-bump
branch
from
7115b58
to
495121f
Compare
|
After merging #7, I tried the "rebase" via GH GUI. It worked well, but the commits are no longer signed by me (obviously). I'll re-push my locally signed commits. |
|
The CI failure smells funny, it keeps talking about Gradle 6.7: But the wrapper is 6.7. I learned that you can clear the GH caches via GH CLI, so I did: Let's see now... |
|
Didn't help. Next I'll try to avoid the deprecated |
|
Also didn't help. BTW I see that 6.7 comes from our test sources, where we explicitly run a test project on Gradle 6.7. But the same thing happens locally and is green... |
|
It's environmental, maybe JDK version, maybe something else. I'll add build scans to compare them local vs CI. |
|
Yep, CI runs on Java 11, local on 8: |
|
Argh, still locally green on Java 11. Hold the phone, I didn't inspect the test failure: It's definitely environmental. Suspects:
|
|
After cleaning my Gotta make the test better isolated from the env. |
Now the `PublishTest` reproduces locally: ``` java.lang.AssertionError: Expecting file: </Users/mkwidzinski/.m2/repository/com/atlassian/performance/tools/publish-test/0.3.0-SNAPSHOT/publish-test-0.3.0-SNAPSHOT.pom> to exist. ``` It might look sketchy that we're mutating `~/.m2` in tests. I thought about publishing to a custom isolated repo. There are [`flatDir` repos], but they work differently: > This type of repository does not support any meta-data formats like Ivy XML or Maven POM files. POM generation is a crucial part of publication, so that would make the test lose too much value. [`flatDir` repos]: https://docs.gradle.org/7.6.2/userguide/declaring_repositories.html#sub:flat_dir_resolver
We had to change the release tags for double-bump repro in 32a5808
No description provided.