chore: update meetings.json and newsrooom_videos.json #3326
Conversation
asyncapi-bot
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe changes involve modifications to the Changes
Suggested labels
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3326 +/- ##
=======================================
Coverage 47.32% 47.32%
=======================================
Files 22 22
Lines 672 672
=======================================
Hits 318 318
Misses 354 354 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
config/meetings.json (1)
150-150: Consider using consistent naming for conference-related meetings.The title "Conference Dry Run" differs from the naming pattern used by other conference entries ("AsyncAPI Online Conference 2024 Dry-Run"). Consider updating for consistency:
- "title": "Conference Dry Run", + "title": "AsyncAPI Online Conference 2024 Dry-Run 2",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- config/meetings.json (1 hunks)
🔇 Additional comments (1)
config/meetings.json (1)
149-154: LGTM on structure and data format.The new entry follows the correct JSON structure and includes all required fields (title, calLink, url, banner, date) with proper formatting.
| { | ||
| "title": "Conference Dry Run", | ||
| "calLink": "https://www.google.com/calendar/event?eid=ZmR1c25lZG1wc2swOWloNDd2c2VudWc5OTggY19xOXRzZWlnbG9tZHNqNm5qdWh2YnB0czExY0Bn", | ||
| "url": "https://github.com/asyncapi/community/issues/1566", | ||
| "banner": "", | ||
| "date": "2024-10-28T16:00:00.000Z" |
There was a problem hiding this comment.
💡 Codebase verification
Maintain consistent naming for conference-related events
The file shows three conference-related events in chronological order:
- "AsyncAPI Online Conference 2024 Dry-Run" (Oct 18)
- "Conference Dry Run" (Oct 28)
- "AsyncAPI Online Conference 2024" (Oct 30)
The new entry should follow the established naming pattern. Suggest renaming "Conference Dry Run" to "AsyncAPI Online Conference 2024 Dry-Run 2" for consistency and clarity.
🔗 Analysis chain
Verify the need for multiple conference dry runs.
I notice there are now three conference-related meetings scheduled:
- "AsyncAPI Online Conference 2024 Dry-Run" on Oct 18
- "Conference Dry Run" (this new entry) on Oct 28
- "AsyncAPI Online Conference 2024" on Oct 30
While multiple dry runs might be intentional, please verify if this is needed.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if the multiple dry runs are discussed in the linked issues
echo "Checking issue discussions for dry run context..."
gh issue view asyncapi/community#1559 # First dry run
gh issue view asyncapi/community#1566 # Second dry run
Length of output: 284
Script:
#!/bin/bash
# Let's verify the chronological order and naming patterns of conference meetings
rg -U "\"title\".*Conference.*\"date\".*2024" config/meetings.json
Length of output: 64
Script:
#!/bin/bash
# Let's check the entire meetings.json content to analyze conference-related entries
cat config/meetings.json
Length of output: 7523
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3326--asyncapi-website.netlify.app/ |
asyncapi-bot
deleted the
update-meetings/1a1d9402a546c75a74080c21b077126fd0d01ede
branch
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit