chore: update meetings.json and newsrooom_videos.json #3425
Conversation
asyncapi-bot
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request introduces a new entry in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
config/meetings.json (1)
Line range hint
1-140: Consider maintaining chronological order of meetingsThe entries appear to be mostly chronological but not strictly ordered by date. Consider maintaining strict chronological ordering to improve readability and maintenance.
Here's a script to verify the chronological order:
#!/bin/bash # Description: Check if meetings are in chronological order # Expected: No output if ordered correctly, otherwise shows out-of-order entries jq -r ' . as $meetings | length as $len | range(0; $len-1) | . as $i | if ($meetings[$i].date > $meetings[$i+1].date) then "\($meetings[$i].date) > \($meetings[$i+1].date)" else empty end ' config/meetings.json
| }, | ||
| { | ||
| "title": "Community Meeting", | ||
| "calLink": "https://www.google.com/calendar/event?eid=NmQzNTJzbW91NTNscGo4dnJoMWNlM3J2YnMgY19xOXRzZWlnbG9tZHNqNm5qdWh2YnB0czExY0Bn", | ||
| "url": "https://github.com/asyncapi/community/issues/1596", | ||
| "banner": "https://github.com/user-attachments/assets/ff469484-a2c5-4aa2-8652-782f017947fb", | ||
| "date": "2024-11-26T16:00:00.000Z" |
There was a problem hiding this comment.
💡 Codebase verification
Entries in meetings.json are not in chronological order
The new Community Meeting entry is valid and consistent, but the file's entries are not properly sorted by date. The sort command detected that 2024-09-03T08:00:00.000Z is out of order, indicating that meetings are not chronologically arranged.
- Consider sorting the meetings array by date to maintain consistent chronological order
🔗 Analysis chain
LGTM! The new meeting entry follows the established structure.
The new Community Meeting entry maintains consistency with:
- All required fields present
- Proper JSON syntax
- ISO 8601 date format
- Valid GitHub issue reference pattern
Let's verify the GitHub issue reference and calendar link:
Verified: GitHub issue and meeting details are consistent
The GitHub issue exists and contains matching information:
- Issue fix: update @asyncapi/modelina to 1.4.0 version #1596 is open and titled "Community Meeting, 16:00 UTC Tuesday November 26th 2024"
- The meeting time in the issue (16:00 UTC) matches the ISO date in meetings.json
- The banner URL in meetings.json matches the one in the issue body
- The issue was created by asyncapi-bot and is properly labeled as "meeting"
Let's verify the chronological order of entries:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the GitHub issue exists and is accessible
# Expected: Status code 200 for valid issue
gh api \
-H "Accept: application/vnd.github+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
repos/asyncapi/community/issues/1596
Length of output: 4631
Script:
#!/bin/bash
# Check if entries are sorted by date
cat config/meetings.json | jq -r '.[] | .date' | sort -c
Length of output: 104
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3425 +/- ##
=======================================
Coverage 67.77% 67.77%
=======================================
Files 21 21
Lines 664 664
=======================================
Hits 450 450
Misses 214 214 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3425--asyncapi-website.netlify.app/ |
asyncapi-bot
deleted the
update-meetings/b9b8e5790ccf7ebdebbe2bd4dab80673724aa071
branch
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit