-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add deployment solution to digital ocean app platform #430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@derberg A small review of GitHub workflow would be appreciated. |
Comment moved to #317 (comment) |
@smoya @derberg The PR has been updated. Successful workflow run :- https://github.com/ash17290/server-api/actions/runs/7525186615/job/20481139953 |
Hello, @Shurtu-gal! 👋🏼
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look Ok to me. However, we would need to manually deploy to DO servers on AsyncAPI Account.
Im on holidays, coming back next monday. I wont be able to deploy it until then and see if everything on Terraform side works as expected.
Digital Ocean Application has been depoyed successfully using the terraform file @Shurtu-gal created. @fmvilas added the proper All seems working properly, the transition from K8s to App Platform happened smoothly. BTW, we do not have K8s on Digital Ocean anymore 🎉 cc @derberg Now I'm gonna proceed configuring the env vars for the GH action to work. |
@Shurtu-gal Do you believe you could update the docs of this repo mentioning how the deploy of the infra works, and how deploys of the app work as well? Can be done in a different PR, not affecting in this case to the Bounty's timeline unless you want to do it here. |
Sure, I can do it here itself. |
@smoya done the readme update. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@@ -55,6 +55,24 @@ server is ready to use on [http://localhost:80](http://localhost:80). | |||
2. Write code and tests. | |||
3. Make sure all tests pass `npm test` | |||
|
|||
## Deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!! 👏 👏
DO TOKEN secret added. Time to merge and test with a new release. Awesome work @Shurtu-gal !!! |
/rtm |
@all-contributors please add @Shurtu-gal for doc, infra |
I've put up a pull request to add @Shurtu-gal! 🎉 |
@asyncapi/bounty_team |
Description
Proof that it works
Things to be noted by the maintainer
Note: this is a single-time process.
Related issue(s)
Fixes #317