Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deployment solution to digital ocean app platform #430

Merged
merged 11 commits into from
Jan 30, 2024

Conversation

Shurtu-gal
Copy link
Contributor

Description

  • Add workflow for deployment to digital ocean droplets
  • Remove k8s helm chart files
  • Add digital ocean terraform files

Proof that it works

Things to be noted by the maintainer

Note: this is a single-time process.

Related issue(s)
Fixes #317

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Shurtu-gal
Copy link
Contributor Author

@derberg A small review of GitHub workflow would be appreciated.

terraform.tfstate Outdated Show resolved Hide resolved
@smoya
Copy link
Member

smoya commented Jan 11, 2024

Comment moved to #317 (comment)

@Shurtu-gal Shurtu-gal requested a review from smoya January 11, 2024 12:45
@Shurtu-gal
Copy link
Contributor Author

@asyncapi-bot
Copy link
Contributor

Hello, @Shurtu-gal! 👋🏼

    I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!

    At the moment the following comments are supported in pull requests:

    - `/ready-to-merge` or `/rtm` - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
    - `/do-not-merge` or `/dnm` - This comment will block automerging even if all conditions are met and ready-to-merge label is added
    - `/autoupdate` or `/au` - This comment will add `autoupdate` label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR.

deployments/droplets/main.tf Outdated Show resolved Hide resolved
deployments/apps/main.tf Show resolved Hide resolved
deployments/apps/main.tf Outdated Show resolved Hide resolved
deployments/apps/main.tf Show resolved Hide resolved
@Shurtu-gal Shurtu-gal requested a review from smoya January 15, 2024 08:58
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, as @smoya is a maintainer in this repo and approves things, and obviously knows what he's doing 😄 I'm not gonna involve in review

@smoya just once merged please make it clear in #317 that bounty issue is completed

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look Ok to me. However, we would need to manually deploy to DO servers on AsyncAPI Account.

Im on holidays, coming back next monday. I wont be able to deploy it until then and see if everything on Terraform side works as expected.

@Shurtu-gal Shurtu-gal requested a review from smoya January 29, 2024 16:13
@smoya
Copy link
Member

smoya commented Jan 29, 2024

Digital Ocean Application has been depoyed successfully using the terraform file @Shurtu-gal created. @fmvilas added the proper CNAME record into api.asyncapi.com to server-api-84f2u.ondigitalocean.app, which is the internal Digital Ocean domain for server-api app.

All seems working properly, the transition from K8s to App Platform happened smoothly. BTW, we do not have K8s on Digital Ocean anymore 🎉 cc @derberg

Now I'm gonna proceed configuring the env vars for the GH action to work.

@smoya
Copy link
Member

smoya commented Jan 29, 2024

Now I'm gonna proceed configuring the env vars for the GH action to work.

Ok, this is embarrassing but I have no powers for setting secrets for the CI. Would you @derberg @fmvilas help me? Thanks!

@smoya smoya changed the title feat: add deployment solution to digital ocean droplets feat: add deployment solution to digital ocean app platform Jan 29, 2024
@smoya
Copy link
Member

smoya commented Jan 29, 2024

@Shurtu-gal Do you believe you could update the docs of this repo mentioning how the deploy of the infra works, and how deploys of the app work as well? Can be done in a different PR, not affecting in this case to the Bounty's timeline unless you want to do it here.

@Shurtu-gal
Copy link
Contributor Author

Sure, I can do it here itself.

@Shurtu-gal
Copy link
Contributor Author

@smoya done the readme update.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Shurtu-gal Shurtu-gal requested a review from smoya January 29, 2024 18:18
Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@@ -55,6 +55,24 @@ server is ready to use on [http://localhost:80](http://localhost:80).
2. Write code and tests.
3. Make sure all tests pass `npm test`

## Deployment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! 👏 👏

@smoya
Copy link
Member

smoya commented Jan 30, 2024

DO TOKEN secret added. Time to merge and test with a new release.

Awesome work @Shurtu-gal !!!

@smoya
Copy link
Member

smoya commented Jan 30, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 4589e2e into asyncapi:master Jan 30, 2024
11 checks passed
@smoya
Copy link
Member

smoya commented Jan 30, 2024

@all-contributors please add @Shurtu-gal for doc, infra

Copy link
Contributor

@smoya

I've put up a pull request to add @Shurtu-gal! 🎉

@aeworxet
Copy link

aeworxet commented Feb 6, 2024

@asyncapi/bounty_team

@aeworxet aeworxet assigned Shurtu-gal and unassigned Shurtu-gal Feb 14, 2024
@Shurtu-gal Shurtu-gal deleted the feat/droplet branch March 20, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

Suggestion to stop hosting server-api on k8s
5 participants