Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to wake dev deployments on deploy #87

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+165 −11
Open

Add option to wake dev deployments on deploy #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bca88ba
Add option to wake dev deployments on deploy
feluelle Oct 25, 2024
fecbb5d
Add example to README
feluelle Oct 25, 2024
923998a
Add hibernation spec validation
feluelle Oct 25, 2024
9ca0699
jq compact json
feluelle Oct 25, 2024
d292e16
Wait for the deployment to wake up
feluelle Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/e2e/get_deployment_info/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ outputs:
desired_image_version:
description: The image version
value: ${{ steps.get-deployment-info.outputs.desired_image_version }}
hibernation_spec:
description: The hibernation spec
value: ${{ steps.get-deployment-info.outputs.hibernation_spec }}

runs:
using: "composite"
Expand All @@ -39,5 +42,7 @@ runs:
fi
desired_dag_tarball_version=$(cat response.json | jq -r '.desiredDagTarballVersion')
desired_image_version=$(cat response.json | jq -r '.desiredImageVersion')
hibernation_spec=$(cat response.json | jq -rc '.scalingSpec.hibernationSpec')
echo "desired_dag_tarball_version=$desired_dag_tarball_version" >> $GITHUB_OUTPUT
echo "desired_image_version=$desired_image_version" >> $GITHUB_OUTPUT
echo "hibernation_spec=$hibernation_spec" >> $GITHUB_OUTPUT
23 changes: 23 additions & 0 deletions .github/workflows/e2e/validate_deployment/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ inputs:
is_no_deploy:
description: If the deploy test was a no-op
default: false
is_wake_on_deploy:
description: If the deploy test was a wake-on-deploy
default: false
dag_tarball_version_before:
description: The desired DAG tarball version before the test
required: true
Expand All @@ -20,6 +23,12 @@ inputs:
image_version_after:
description: The image version after the test
required: true
hibernation_spec_before:
description: The hibernation spec before the test
required: true
hibernation_spec_after:
description: The hibernation spec after the test
required: true

runs:
using: "composite"
Expand Down Expand Up @@ -55,3 +64,17 @@ runs:
fi
echo "Deploy Action validation failed: neither desiredDagTarballVersion or imageVersion were updated after the test"
exit 1
- name: Validate Hibernation Spec
id: validate-hibernation-spec
shell: bash
run: |
if [[ "${{ inputs.is_wake_on_deploy }}" == "true" ]]; then
if [[ "${{ inputs.hibernation_spec_before }}" == "${{ inputs.hibernation_spec_after }}" ]]; then
echo "Hibernation Spec validation succeeded: hibernation spec was not updated after the test"
exit 0
fi
echo "Hibernation Spec validation failed: hibernation spec updated"
exit 1
fi
Loading
Loading