Add option to wake dev deployments on deploy #87
+144
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feluelle
force-pushed
the
feature/deploy-to-dev-deployments
branch
3 times, most recently
from
c38bbd6
to
fcb7811
Compare
This adds a new `wake-on-deploy` input that allows for creating a hibernation override that will ensure the dev deployment is awake for the time of deploying.
feluelle
force-pushed
the
feature/deploy-to-dev-deployments
branch
from
fcb7811
to
bca88ba
Compare
feluelle
changed the title
neel-astro
reviewed
Oct 25, 2024
| @@ -744,6 +779,7 @@ jobs: | |||
| copy-connections: false | |||
| copy-airflow-variables: false | |||
| copy-pools: false | |||
| wake-on-deploy: true | |||
There was a problem hiding this comment.
for test completeness, should we validate that the deployment is not hibernating at the end of deploy?
There was a problem hiding this comment.
But it can be hibernating and that is okay. It should only be non-hibernating during deploy which is guaranteed because otherwise, the deploy would fail.
But what we could and should do is assert that the hibernation spec override definition is not set.
There was a problem hiding this comment.
yeah that makes sense, to validate that the hibernation spec is intact after the deploy
| @@ -94,6 +94,10 @@ inputs: | |||
| required: false | |||
| default: false | |||
| description: "Whether to checkout submodules when cloning the repository: `false` to disable (default), `true` to checkout submodules or `recursive` to recursively checkout submodules. Works only when `checkout` is set to `true`." | |||
| wake-on-deploy: | |||
There was a problem hiding this comment.
Can we update the README as well with the new parameter, and also leave an example for the same 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new
wake-on-deployinput that creates a hibernation override to ensure the dev deployment is awake before deploying and resumes hibernation schedules afterward.Note
This means it will override whatever existing hibernation override is on the deployment when
wake-on-deployis used.Motivation
fixes: #81
Testing