-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to wake dev deployments on deploy #87
base: main
Are you sure you want to change the base?
Conversation
c38bbd6
to
fcb7811
Compare
This adds a new `wake-on-deploy` input that allows for creating a hibernation override that will ensure the dev deployment is awake for the time of deploying.
fcb7811
to
bca88ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments, but lgtm otherwise
@@ -744,6 +779,7 @@ jobs: | |||
copy-connections: false | |||
copy-airflow-variables: false | |||
copy-pools: false | |||
wake-on-deploy: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for test completeness, should we validate that the deployment is not hibernating at the end of deploy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it can be hibernating and that is okay. It should only be non-hibernating during deploy which is guaranteed because otherwise, the deploy would fail.
But what we could and should do is assert that the hibernation spec override definition is not set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that makes sense, to validate that the hibernation spec is intact after the deploy
@@ -94,6 +94,10 @@ inputs: | |||
required: false | |||
default: false | |||
description: "Whether to checkout submodules when cloning the repository: `false` to disable (default), `true` to checkout submodules or `recursive` to recursively checkout submodules. Works only when `checkout` is set to `true`." | |||
wake-on-deploy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the README as well with the new parameter, and also leave an example for the same 🙂
Description
This adds a new
wake-on-deploy
input that creates a hibernation override to ensure the dev deployment is awake before deploying and resumes hibernation schedules afterward.Note
This means it will override whatever existing hibernation override is on the deployment when
wake-on-deploy
is used.Motivation
fixes: #81
Testing