Fix only create task group and test task only if model has test #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
raffifu
force-pushed
the
fix/task-group
branch
from
0012d84
to
06f2b38
Compare
raffifu
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
==========================================
+ Coverage 92.37% 92.41% +0.04%
==========================================
Files 49 49
Lines 1941 1952 +11
==========================================
+ Hits 1793 1804 +11
Misses 148 148
☔ View full report in Codecov by Sentry. |
tatiana
approved these changes
Sep 25, 2023
tatiana
added a commit
that referenced
this pull request
Sep 27, 2023
Bug fixes * Fix using ``ExecutionMode.KUBERNETES`` by @pgoslatara and @tatiana in #554 * Add support to ``apache-airflow-providers-cncf-kubernetes < 7.4.0`` by @tatiana in #553 * Improve error message in ``config.py`` by @meyobagero in #532 * Use ``returncode`` instead of ``stderr`` to determine dbt graph loading errors by @cliff-lau-cloverhealth in #547 * Fix only create task group and test task only if model has test by @raffifu in #543 * Fix ``on_warning_callback`` behaviour on ``DbtTestLocalOperator`` by @edgga, @marco9663 and @tatiana in #558 * Fix ``DbtTestOperator`` when test does not have ``test_metadata`` by @tatiana in #558 * Fix ``target-path`` not specified issue in ``dbt-project.yml`` by @tatiana in #533 Others * Docs: add reference links to dbt and Airflow columns by @TJaniF in #542 * pre-commit updates #552 and #546
This was referenced Sep 27, 2023
Closed
2 tasks
tatiana
pushed a commit
that referenced
this pull request
Sep 28, 2023
tatiana
pushed a commit
that referenced
this pull request
Sep 28, 2023
This PR will only create task group if `dbt` test exist by adding propery `has_test` on `DbtNode`. The test dependency will be updated after loading the dbt project into `DbtGraph` Closes: #531
tatiana
added a commit
that referenced
this pull request
Sep 28, 2023
Bug fixes * Only create task group and test task only if the model has a test by @raffifu in #543 * Fix parsing test nodes when using the custom load method (LoadMethod.CUSTOM) by @raffifu in #563 * Fix ``DbtTestOperator`` when test does not have ``test_metadata`` by @javihernovoa and @tatiana in #565 * Support dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 by @tatiana in #564
Merged
tatiana
added a commit
that referenced
this pull request
Sep 28, 2023
Bug fixes * Only create task group and test task only if the model has a test by @raffifu in #543 * Fix parsing test nodes when using the custom load method (LoadMethod.CUSTOM) by @raffifu in #563 * Fix ``DbtTestOperator`` when test does not have ``test_metadata`` by @javihernovoa and @tatiana in #565 * Support dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 by @tatiana in #564
|
This was released as part of 1.1.3 🎉 |
tatiana
added a commit
that referenced
this pull request
Sep 29, 2023
Bug fixes
* Only create task group and test task only if the model has a test by
@raffifu in #543
* Fix parsing test nodes when using the custom load method
(`LoadMethod.CUSTOM`) by @raffifu in #563
* Fix `DbtTestOperator` when test does not have ``test_metadata`` by
@javihernovoa and @tatiana in #565
* Support dbt 1.6 and `apache-airflow-providers-cncf-kubernetes` 7.3.0
by @tatiana in #564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will only create task group if
dbttest exist by adding properyhas_testonDbtNode. The test dependency will be updated after loading the dbt project intoDbtGraphRelated Issue(s)
closes #531
Checklist