-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing test nodes when using the custom load method (LoadMethod.CUSTOM) #563
Conversation
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
==========================================
- Coverage 92.88% 92.83% -0.06%
==========================================
Files 49 49
Lines 1968 1982 +14
==========================================
+ Hits 1828 1840 +12
- Misses 140 142 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this impressive quick fix, @raffifu!
Is there any chance you could add a unit test to cover
cosmos/dbt/parser/project.py#L368
?
We'll release this fix as part of the 1.2 release - we should have an alpha pre-release soon.
Bug fixes * Only create task group and test task only if the model has a test by @raffifu in #543 * Fix parsing test nodes when using the custom load method (LoadMethod.CUSTOM) by @raffifu in #563 * Fix ``DbtTestOperator`` when test does not have ``test_metadata`` by @javihernovoa and @tatiana in #565 * Support dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 by @tatiana in #564
Bug fixes * Only create task group and test task only if the model has a test by @raffifu in #543 * Fix parsing test nodes when using the custom load method (LoadMethod.CUSTOM) by @raffifu in #563 * Fix ``DbtTestOperator`` when test does not have ``test_metadata`` by @javihernovoa and @tatiana in #565 * Support dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 by @tatiana in #564
Bug fixes * Only create task group and test task only if the model has a test by @raffifu in #543 * Fix parsing test nodes when using the custom load method (`LoadMethod.CUSTOM`) by @raffifu in #563 * Fix `DbtTestOperator` when test does not have ``test_metadata`` by @javihernovoa and @tatiana in #565 * Support dbt 1.6 and `apache-airflow-providers-cncf-kubernetes` 7.3.0 by @tatiana in #564
This was released as part of 1.2: |
Description
This PR Added a functionality to parse Test on the custom parser. After implementing #543, there's an issue using
load_via_custom_parser
which doesn't load the test node. That's happen because the implementation in #543 is assume all node doesn't has test. After debugging, i found that theload_via_custom_parser
not return any tests node.Related Issue(s)
closes #561
Checklist