Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-establish pre-3.2.1 copy_data_to_bin behavior #717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Oct 15, 2024

Fixes #716 (and breaks #411 again).


Changes are visible to end-users: yes/no

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no (re-establishes backwards compatible behavior).
  • Suggested release notes appear below: no

Test plan

  • New test cases added

I have manually checked that the new tests:

  • Pass at 3.2.0
  • Fail at 3.2.1

Copy link

aspect-workflows bot commented Oct 15, 2024

Test

All tests were cache hits

144 tests (100.0%) were fully cached saving 10s.


Buildifier      Format

@gzm0 gzm0 changed the title fix: re-establish pre-3.2.1 data runfile behavior fix: re-establish pre-3.2.1 data copy_to_bin behavior Oct 15, 2024
@gzm0 gzm0 changed the title fix: re-establish pre-3.2.1 data copy_to_bin behavior fix: re-establish pre-3.2.1 copy_data_to_bin behavior Oct 15, 2024
@gzm0 gzm0 force-pushed the fix-copy-runfiles branch 2 times, most recently from e6e51e5 to 6de1bc2 Compare October 15, 2024 12:06
@gzm0 gzm0 marked this pull request as ready for review October 15, 2024 12:09
@gzm0
Copy link
Contributor Author

gzm0 commented Oct 15, 2024

Ready for review.

An alternative would be to not include the additional parameter in the macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: #710 changed copy_runfiles_to_bin behavior of ts_project if transpiler is set
1 participant