fix: re-establish pre-3.2.1 data copy_to_bin behavior

ts/defs.bzl

@@ -59,6 +59,7 @@ def ts_project(
  declaration_dir = None,
  out_dir = None,
  root_dir = None,
+ copy_data_to_bin = None,
  supports_workers = -1,
  **kwargs):
  """Compiles one TypeScript project using `tsc --project`.
@@ -240,6 +241,9 @@ def ts_project(
  ts_build_info_file: The user-specified value of `tsBuildInfoFile` from the tsconfig.
  Helps Bazel to predict the path where the .tsbuildinfo output is written.
 
+ copy_data_to_bin: When True, `data` files are copied to the Bazel output tree before being passed as inputs to runfiles.
+ Defaults to `transpiler != None` due to backwards compatiblity (see #716/ #411).
+
  supports_workers: Whether the "Persistent Worker" protocol is enabled.
  This uses a custom `tsc` compiler to make rebuilds faster.
  Note that this causes some known correctness bugs, see
@@ -421,6 +425,9 @@ def ts_project(
  "//conditions:default": False,
  })
 
+ if copy_data_to_bin == None:
+ copy_data_to_bin = transpiler != None
+
  ts_project_rule(
  name = name,
  srcs = srcs,
@@ -460,6 +467,7 @@ def ts_project(
  is_typescript_5_or_greater = is_typescript_5_or_greater,
  validate = validate,
  validator = validator,
+ copy_data_to_bin = copy_data_to_bin,
  **kwargs
  )
 

ts/private/ts_lib.bzl

@@ -116,6 +116,10 @@ https://docs.aspect.build/rulesets/aspect_rules_js/docs/js_library#deps for more
  default = True,
  ),
  "validator": attr.label(mandatory = True, executable = True, cfg = "exec"),
+ "copy_data_to_bin": attr.bool(
+ doc = """When True, data files are copied to the Bazel output tree before being passed as inputs to runfiles.""",
+ default = False,
+ ),
  "_options": attr.label(
  default = "@aspect_rules_ts//ts:options",
  ),

ts/private/ts_project.bzl

@@ -325,6 +325,8 @@ See https://github.com/aspect-build/rules_ts/issues/361 for more details.
  sources = output_sources_depset,
  data = ctx.attr.data,
  deps = srcs_tsconfig_deps,
+ data_files = ctx.files.data,
+ copy_data_files_to_bin = ctx.attr.copy_data_to_bin,
  )
 
  providers = [

ts/test/copy_data_to_bin/BUILD.bazel

@@ -0,0 +1,78 @@
+# Test data file copying behavior. See
+#
+# https://github.com/aspect-build/rules_ts/issues/411
+# https://github.com/aspect-build/rules_ts/issues/716
+#
+# Ideally, the behaviors with and without `transpiler` would align, but that is
+# backwards incompatible.
+
+load("@aspect_bazel_lib//lib:copy_file.bzl", "copy_file")
+load("@aspect_bazel_lib//lib:testing.bzl", "assert_contains")
+load("@aspect_rules_js//js:defs.bzl", "js_binary", "js_run_binary")
+load("//ts:defs.bzl", "ts_project")
+load("//ts/test:mock_transpiler.bzl", "mock")
+
+copy_file(
+ name = "no_transpiler_src",
+ src = "check_has_data.ts",
+ out = "no_transpiler.ts",
+)
+
+ts_project(
+ name = "no_transpiler",
+ srcs = ["no_transpiler.ts"],
+ data = ["data.txt"],
+ tsconfig = {},
+)
+
+js_binary(
+ name = "no_transpiler_bin",
+ data = [":no_transpiler"],
+ entry_point = "no_transpiler.ts",
+)
+
+js_run_binary(
+ name = "no_transpiler_gen",
+ chdir = package_name(),
+ stdout = "no_transpiler_out.txt",
+ tool = ":no_transpiler_bin",
+)
+
+assert_contains(
+ name = "no_transpiler_test",
+ actual = "no_transpiler_out.txt",
+ expected = "false",
+)
+
+copy_file(
+ name = "with_transpiler_src",
+ src = "check_has_data.ts",
+ out = "with_transpiler.ts",
+)
+
+ts_project(
+ name = "with_transpiler",
+ srcs = ["with_transpiler.ts"],
+ data = ["data.txt"],
+ transpiler = mock,
+ tsconfig = {},
+)
+
+js_binary(
+ name = "with_transpiler_bin",
+ data = [":with_transpiler"],
+ entry_point = "with_transpiler.js",
+)
+
+js_run_binary(
+ name = "with_transpiler_gen",
+ chdir = package_name(),
+ stdout = "with_transpiler_out.txt",
+ tool = ":with_transpiler_bin",
+)
+
+assert_contains(
+ name = "with_transpiler_test",
+ actual = "with_transpiler_out.txt",
+ expected = "true",
+)

ts/test/copy_data_to_bin/check_has_data.ts

@@ -0,0 +1,4 @@
+// @ts-ignore
+const { readdirSync } = require("node:fs");
+
+console.log(readdirSync(".").includes("data.txt"));

ts/test/copy_data_to_bin/data.txt

@@ -0,0 +1 @@
+irrelevant data in a file