Fix transitive propagation of npm deps

[mvukov]

Fixes:

• [Bug]: Transitive npm deps not propagated through npm_package by default #268
• [Bug]: Dependencies are not correctly propagated to/by jest_test rules_jest#72

[mvukov]

@alexeagle @thesayyn PTAL.

[thesayyn]

@gregmagolan as he knows the JSInfo provider better.

[gregmagolan]

Adding this my list of OSS bug squashing for later this week

[alexeagle]

We just need to be careful we don't re-introduce eager type-checking or cascading rebuilds.

[gregmagolan]

I'll keep it in mind. We did add analysis test cases to cover that now.

[mvukov]

Anything I can help with?

[flolu]

@gregmagolan @thesayyn @alexeagle why isn't that merged yet? rules_js#677 still persists

[gregmagolan]

Thanks for the ping. I didn't have time to get to this before the Christmas break. Will look soon. This needs a bit of time to understand the side-effects of this change. In the meantime, it's a small patch to carry downstream if you need this change.

[flolu]

@gregmagolan awesome, thanks! How would I apply this patch to ts_project.bzl and use it for my project in the meantime?

[gregmagolan]

It's a very common practice to patch Bazel rules with http_archive in your WORKSPACE. Even rule sets sometimes patch other rule sets. For example, https://github.com/bazelbuild/rules_go/blob/master/go/private/repositories.bzl#L78

http_archive docs: https://bazel.build/rules/lib/repo/http#http_archive-patches

[mvukov]

@gregmagolan Friendly ping :) PTAL when you find some time.

[gregmagolan]

Turns out that @jbedard and I have been discussing the underlying issue that the PR address already. I go into the details of the problem in this comment #268 (comment). The principled fix for this starts with a PR in rules_js to introduce a dev_npm_deps attribute. Closing this PR as the fix will take a different shape once the change in rules_js lands. Will leave #268 open.