feat: add dev_deps attribute to js_library #818
Conversation
| providers = [JsInfo], | ||
| ), | ||
| "dev_deps": attr.label_list( | ||
| doc = """Development dependencies of this target. |
There was a problem hiding this comment.
"development" means compile-time but not runtime? Is there a better term for that? :/
There was a problem hiding this comment.
npm docs say "devDependencies": Packages that are only needed for local development and testing." tho that doesn't translate over perfectly to rules_js.
That is the idea, however, when it comes propagating deps through the linker. My thinking is to use a term that the js ecosystem is already familiar with. "compile-time" is not quite right either since the deps are propagated to downstream ts_project targets; just not to runfiles or as transitive deps of downstream linked npm_package targets.
gregmagolan
force-pushed
the
npm_dev_deps
branch
2 times, most recently
from
8bc65eb
to
f335efd
Compare
gregmagolan
force-pushed
the
npm_dev_deps
branch
from
f335efd
to
58e712c
Compare
|
We may add this in the future for even more fine-grained control of what gets propagated to the linker but for now we're going to go with #860 |
Inspired by aspect-build/rules_ts#280.
Addresses aspect-build/rules_ts#268.
Will require a MINOR release after this lands as this changes the default behaviour of
deps. Still needs some tests.