Add namespaces to PREMIS plugin to prevent ValueError: Invalid tag name on serialization #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw4l
force-pushed
the
dev/handle-characterization-tool-namespaces
branch
from
90d73ff
to
a3c1a9d
Compare
tw4l
changed the title
tw4l
force-pushed
the
dev/handle-characterization-tool-namespaces
branch
from
a3c1a9d
to
f79fbf9
Compare
tw4l
force-pushed
the
dev/handle-characterization-tool-namespaces
branch
from
6d0223a
to
2bb376e
Compare
tw4l
changed the title
sevein
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #94
This PR adds characterization tool namespaces to the PREMIS plugin's namespaces dictionaries to prevent serialization errors when serializing
PREMISObjects that contain characterization tool output to XML.This will enable adding raw PREMIS Object XML to the AIPscan database for files with characterization tool output.
Note that linting is currently failing because of the version of Black we are using. See: https://stackoverflow.com/questions/71673404/importerror-cannot-import-name-unicodefun-from-click. Upgrading Black to 22.3.0 also causes linting failures, as the newer version of Black wants us to drop explicit unicode strings (e.g.
u"something"). I think that might be better handled in a separate PR.