Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add PREMIS Object XML to file model and template to make characterization tool output visible #180

Closed
wants to merge 2 commits into from

Conversation

tw4l
Copy link
Contributor

@tw4l tw4l commented Sep 7, 2022

This PR adds the PREMIS Object XML for files that have a premis:objectCharacteristicsExtension. This allows for users to see characterization tool output in its XML form within AIPscan.

This currently doesn't work due to artefactual-labs/mets-reader-writer#94. First, artefactual-labs/mets-reader-writer#96 will need to be merged and then a 0.3.22 release of metsrw uploaded to PyPI.

Commit c3a098d is left here for now to show what is possible without serializing the PREMISObject to XML - the result is that the tuple representation of the characteristics extension is stored in the database, which is harder for users to read.

Currently this is the metsrw tuple representation of the output, which isn't
the most user-friendly output. It might be better to skip metsrw and just
store a blob from the original METS XML or try to turn it into key-value pairs.
@mcantelon
Copy link
Member

Hi Tessa! Hope you're doing well! There seemed to be an issue with the objectCharacteristicsExtension in METSRW, but I made some tweaks to this PR and added the feature in d7e9566 (and b8e5c30 as fix to mistake I'd made).

@mcantelon mcantelon closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants