fix: accept raw values as well as hash #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwared
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
non-blocking nit below
I've also tested with the epoch_change_fixture.json from argumentcomputer/zk-light-clients#216 and it works perfectly!
| // Check the bit length (bytes * 8 should be 256 bits), hash if necessary | ||
| let bit_length = decoded_bytes.len() * 8; | ||
|
|
||
| let public_inputs: String = if bit_length > 256 { |
There was a problem hiding this comment.
I think it would be better if we always unconditionally did the Sha256 hashing here, since this heuristic would be confusing to callers.
What about removing the if entirely and the assets/fibonacci_fixture.json test case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows passing in the raw values if they haven't been pre-hashed.