Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the verifier always re-hash? #5

Closed
huitseeker opened this issue Sep 11, 2024 · 0 comments · Fixed by #16
Closed

Should the verifier always re-hash? #5

huitseeker opened this issue Sep 11, 2024 · 0 comments · Fixed by #16

Comments

@huitseeker
Copy link
Member

I think it would be better if we always unconditionally did the Sha256 hashing here, since this heuristic would be confusing to callers.

What about removing the if entirely and the assets/fibonacci_fixture.json test case?

Originally posted by @wwared in #4 (comment)

FG: What I'm thinking is that in the unfortunate case where the user has an Insanely long public value string, and does not want to put the pre-image check on-chain, if the verifier always requires re-hashing, there is no verifier that the user could make any use of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant