Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): don't show pagination warning on first page if all are displayed #11979

Merged
merged 1 commit into from
Oct 14, 2023
Merged

fix(ui): don't show pagination warning on first page if all are displayed #11979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/src/app/shared/components/pagination-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ export function PaginationPanel(props: {pagination: Pagination; onChange: (pagin
}>
Next page <i className='fa fa-chevron-right' />
</button>
{props.pagination.limit > 0 ? (
{/* if pagination is used, and we're either not on the first page, or are on the first page and have more records than the page limit */}
{props.pagination.limit > 0 && (props.pagination.offset || (!props.pagination.offset && props.numRecords >= props.pagination.limit)) ? (
<>
<WarningIcon /> Workflows cannot be globally sorted when paginated
</>
Expand Down