fix(ui): don't show pagination warning on first page if all are displayed #11979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayed - example: if you're on the first page and your pagination limit is 50 while you only have 10 total workflows, then the warning shouldn't show, as you already see all 10 workflows - this new logic should handle both the first page and the last page issues - added a comment to word it out as well, which was actually very helpful in debugging and properly writing the logic (as it's a bit convoluted) Signed-off-by: Anton Gilgur <[email protected]>
This was referenced Oct 10, 2023
terrytangyuan
approved these changes
Oct 10, 2023
|
Will include in #11997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes my review comment in #11973 (comment)
Fixes #11968 without a regression
Motivation
Modifications
Verification
Tested manually. See #11973 (comment) for more details
Before:
After:
