Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve Documentation for Scaledown on Aborted Rollout #3835

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

docs: Improve Documentation for Scaledown on Aborted Rollout #3835

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5e5cbd
Improve Documentation for Scaledown on Aborted Rollout
bishalthapa-t Sep 17, 2024
7665aa8
Merge branch 'master' into bishalthapa-t/improve-doc-scaledown-on-abo…
bishalthapa-t Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions docs/features/scaledown-aborted-rs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@ The following table summarizes the behavior under combinations of rollout strate
`abortScaleDownDelaySeconds = nil` is the default, which means in v1.1 across all rollout strategies, the new replicaset
is scaled down in 30 seconds on abort by default.

| strategy | v1.0 behavior | abortScaleDownDelaySeconds | v1.1 behavior |
|--------------------------------------------:|:-----------------------------:|:--------------------------:|:-----------------------------:|
| blue-green | does not scale down | nil | scales down after 30 seconds |
| blue-green | does not scale down | 0 | does not scale down |
| blue-green | does not scale down | N | scales down after N seconds |
| basic canary | rolling update back to stable | N/A | rolling update back to stable |
| canary w/ traffic routing | scales down immediately | nil | scales down after 30 seconds |
| canary w/ traffic routing | scales down immediately | 0 | does not scale down |
| canary w/ traffic routing | scales down immediately | N | scales down after N seconds |
| canary w/ traffic routing + setCanaryScale | does not scale down (bug) | * | should behave like canary w/ traffic routing |
| strategy | v1.0 behavior | abortScaleDownDelaySeconds | v1.1 behavior |
|--------------------------------------------:|:-----------------------------:|:--------------------------:|:---------------------------------------------:|
| blue-green | does not scale down | nil | scales down after 30 seconds |
| blue-green | does not scale down | 0 | does not scale down |
| blue-green | does not scale down | N | scales down after N seconds |
| basic canary | rolling update back to stable | N/A | rolling update back to stable |
| canary w/ traffic routing | scales down immediately | nil | scales down after 30 seconds |
| canary w/ traffic routing | scales down immediately | 0 | scales down immediately |
| canary w/ traffic routing | scales down immediately | N | scales down immediately |
| canary w/ traffic routing + setCanaryScale | scales down immediately | 0 | does not scale down |
| canary w/ traffic routing + setCanaryScale | scales down immediately | N | scales down after N seconds |
| canary w/ traffic routing + setCanaryScale | does not scale down (bug) | * | should behave like canary w/ traffic routing |
Loading