docs: Improve Documentation for Scaledown on Aborted Rollout #3835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishalthapa-t
changed the title
bishalthapa-t
force-pushed
the
bishalthapa-t/improve-doc-scaledown-on-aborted
branch
from
c223de8
to
bcfd6af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3835 +/- ##
==========================================
+ Coverage 83.88% 83.89% +0.01%
==========================================
Files 163 163
Lines 18560 18560
==========================================
+ Hits 15569 15571 +2
+ Misses 2119 2118 -1
+ Partials 872 871 -1 ☔ View full report in Codecov by Sentry. |
Published E2E Test Results 4 files 4 suites 3h 15m 1s ⏱️ For more details on these failures, see this check. Results for commit 7665aa8. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 275 tests 2 275 ✅ 2m 59s ⏱️ Results for commit 7665aa8. ♻️ This comment has been updated with latest results. |
bishalthapa-t
force-pushed
the
bishalthapa-t/improve-doc-scaledown-on-aborted
branch
from
bcfd6af
to
999db8a
Compare
Improves understanding of how scaling down behaves depending on different configurations. • Canary with traffic routing + setCanaryScale does not scales down immediately when `abortScaleDownDelaySeconds = 0`. • Canary with traffic routing + setCanaryScale scales down after some delay of N second `abortScaleDownDelaySeconds = N`. Signed-off-by: Bishal Thapa <[email protected]>
bishalthapa-t
force-pushed
the
bishalthapa-t/improve-doc-scaledown-on-aborted
branch
from
999db8a
to
e5e5cbd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves understanding of how scaling down behaves depending on different configurations:
• Canary with traffic routing + setCanaryScale does not scales down immediately when
abortScaleDownDelaySeconds = 0• Canary with traffic routing + setCanaryScale scales down after some delay of N second
abortScaleDownDelaySeconds = NAddresses the following issue: #1841
Checklist:
"fix(controller): Updates such and such. Fixes #1234".