feat(argo-workflows): add loadBalancerClass field for Service resources #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazal-k
requested review from
vladlosev,
jmeridth,
yu-croco and
tico24
as code owners
6 tasks
gazal-k
force-pushed
the
load-balancer-class-workflows
branch
2 times, most recently
from
e93534c
to
575999f
Compare
gazal-k
force-pushed
the
load-balancer-class-workflows
branch
from
575999f
to
812f8a5
Compare
Most users of ArgoCD may use `Ingress` (and soon `HTTPRoute`), but for those who may want to use `Service` of type `LoadBalancer`, this would be useful. The `loadBalancerClass` field would allow for a `CloudProvider` agnostic way of offloading the reconciliation for Kubernetes Service resources of type `LoadBalancer` to an external controller. Signed-off-by: Gazal Gafoor <[email protected]>
gazal-k
force-pushed
the
load-balancer-class-workflows
branch
from
812f8a5
to
b598a89
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Signed-off-by: Gazal <[email protected]>
jmeridth
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most users of Argo Workflows may use
Ingress(and soonHTTPRoute), but for those who may want to useServiceof typeLoadBalancer, this would be useful. TheloadBalancerClassfield would allow for aCloudProvideragnostic way of offloading the reconciliation for Kubernetes Service resources of typeLoadBalancerto an external controller.Checklist: