Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-cd): add loadBalancerClass field for Service resource #2769

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

gazal-k
Copy link
Contributor

@gazal-k gazal-k commented Jun 17, 2024

Most users of ArgoCD may use Ingress (and soon HTTPRoute), but for those who may want to use Service of type LoadBalancer, this would be useful. The loadBalancerClass field would allow for a CloudProvider agnostic way of offloading the reconciliation for Kubernetes Service resources of type LoadBalancer to an external controller.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@gazal-k gazal-k force-pushed the load-balancer-class branch 2 times, most recently from bcbefa4 to 9944969 Compare June 17, 2024 00:37
@gazal-k gazal-k changed the title feat: add loadBalancerClass field for Service resources feat(argo-cd): add loadBalancerClass field for Service resources Jun 17, 2024
@gazal-k gazal-k marked this pull request as ready for review June 17, 2024 00:38
@yu-croco
Copy link
Collaborator

Hi @gazal-k , thank you for your PR.
Can you please separate PR per chart?
e.g. argo-cd, argo-workflows

@gazal-k gazal-k changed the title feat(argo-cd): add loadBalancerClass field for Service resources feat(argo-cd): add loadBalancerClass field for Service resource Jun 17, 2024
@gazal-k
Copy link
Contributor Author

gazal-k commented Jun 17, 2024

Hi @gazal-k , thank you for your PR. Can you please separate PR per chart? e.g. argo-cd, argo-workflows

Sure, done

Most users of ArgoCD may use `Ingress` (and soon `HTTPRoute`), but for those who may want to use `Service` of type `LoadBalancer`, this would be useful.
The `loadBalancerClass` field would allow for a `CloudProvider` agnostic way of offloading the reconciliation for Kubernetes Service resources of type `LoadBalancer` to an external controller.

Signed-off-by: Gazal Gafoor <[email protected]>
@yu-croco yu-croco merged commit 6946696 into argoproj:main Jun 18, 2024
7 checks passed
@gazal-k gazal-k deleted the load-balancer-class branch June 18, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants