Experimental CI changes #294
+223
−247
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,164 +1,113 @@ | ||
| version: 2.1 | ||
|
|
||
| # orbs: | ||
| # coveralls: coveralls/[email protected] | ||
|
|
||
| workflows: | ||
| ci: | ||
| jobs: | ||
| - lint | ||
| - test: | ||
| matrix: | ||
| parameters: | ||
| # TODO: Revisit why pyenv doesn't recognize 3.12 | ||
| python_version: ["3.8", "3.9", "3.10", "3.11"] # "3.12" | ||
| arangodb_config: ["single", "cluster"] | ||
| arangodb_license: ["community", "enterprise"] | ||
|
There was a problem hiding this comment. Want to clarify - according to the current state of
Perhaps we can revisit the idea of |
||
| arangodb_version: ["3.10.10", "3.11.4", "latest"] | ||
|
|
||
| jobs: | ||
| lint: | ||
| docker: | ||
| - image: python:latest | ||
| steps: | ||
| - checkout | ||
| - run: | ||
| name: Install Dependencies | ||
| command: pip install .[dev] | ||
|
|
||
| - run: | ||
| name: Run black | ||
| command: black --check --verbose --diff --color --config=pyproject.toml ./arango ./tests/ | ||
|
|
||
| - run: | ||
| name: Run flake8 | ||
| command: flake8 ./arango ./tests | ||
|
|
||
| - run: | ||
| name: Run isort | ||
| command: isort --check ./arango ./tests | ||
|
|
||
| - run: | ||
| name: Run mypy | ||
| command: mypy ./arango | ||
|
|
||
| test: | ||
| parameters: | ||
| python_version: | ||
| type: string | ||
| arangodb_config: | ||
| type: string | ||
| arangodb_license: | ||
| type: string | ||
| arangodb_version: | ||
| type: string | ||
| # TODO: Reconsider using a docker image instead of a machine | ||
| # i.e cimg/python:<< parameters.python_version >> | ||
| machine: | ||
| image: ubuntu-2204:current | ||
|
Comment on lines
+55
to
+58
There was a problem hiding this comment. Hopefully we can revisit using We currently rely on |
||
| steps: | ||
| - checkout | ||
|
|
||
| - run: | ||
| name: Set Up ArangoDB | ||
| command: | | ||
| chmod +x starter.sh | ||
| ./starter.sh << parameters.arangodb_config >> << parameters.arangodb_license >> << parameters.arangodb_version >> | ||
|
|
||
| - restore_cache: | ||
| key: pip-and-local-cache | ||
|
|
||
| # TODO: Revisit this bottleneck | ||
| - run: | ||
| name: Setup Python | ||
| command: | | ||
| pyenv --version | ||
| pyenv install -f << parameters.python_version >> | ||
| pyenv global << parameters.python_version >> | ||
|
|
||
| - run: | ||
| name: "Install Dependencies" | ||
| command: pip install -e .[dev] | ||
|
|
||
| - run: docker ps -a | ||
|
|
||
| - run: | ||
| name: "Run pytest" | ||
| command: | | ||
| mkdir test-results | ||
|
|
||
| args=("--junitxml=test-results/junit.xml" "--log-cli-level=DEBUG" "--host" "localhost" "--port=8529") | ||
| if [ << parameters.arangodb_config >> = "cluster" ]; then | ||
| args+=("--cluster" "--port=8539" "--port=8549") | ||
| fi | ||
|
|
||
| if [ << parameters.arangodb_license >> = "enterprise" ]; then | ||
| args+=("--enterprise") | ||
| fi | ||
|
|
||
| echo "Running pytest with args: ${args[@]}" | ||
| pytest --cov=arango --cov-report=xml "${args[@]}" | ||
|
|
||
| - store_artifacts: | ||
| path: test-results | ||
|
|
||
| - store_test_results: | ||
| path: test-results | ||
|
|
||
| # - run: | ||
| # name: Upload to Coveralls | ||
| # command: | | ||
| # if [ "<< parameters.python_version >>" = "3.11" && "<< parameters.arangodb_config >>" = "single" && "<< parameters.arangodb_license >>" = "community" && "<< parameters.arangodb_version >>" = "latest" ]; then | ||
| # coveralls/upload | ||
| # fi | ||
|
Comment on lines
+108
to
+113
There was a problem hiding this comment. Uploading coverage to coveralls won't be possible until we request access from the Organization Admin:
Will figure out who that is.. |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason
pyenv 2.3.37does not recognize3.12when attempting to dopyenv install 3.12...However,
pyenv install 3.12worked fine locally withpyenv 2.3.31🤔will revisit