Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental CI changes #294

Merged
merged 27 commits into from
Nov 17, 2023
Merged

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Nov 9, 2023

Branched from #291

Experimenting with Github Actions & CircleCI to make use of matrices to cover a variety of testing environments

              python_version: ["3.10"] # ["3.8", "3.9", "3.10", "3.11", "3.12"]
              arangodb_config: ["single"] # ["single", "cluster"]
              arangodb_license: ["community"] # ["community", "enterprise"]
              arangodb_version: ["latest"] # ["3.10.10", "3.11.4", "latest"]
  1. Updates .circleci/config.yml
  2. Renames build.yaml to docs.yaml
  3. Updates starter.sh

Comment on lines +108 to +113
# - run:
# name: Upload to Coveralls
# command: |
# if [ "<< parameters.python_version >>" = "3.11" && "<< parameters.arangodb_config >>" = "single" && "<< parameters.arangodb_license >>" = "community" && "<< parameters.arangodb_version >>" = "latest" ]; then
# coveralls/upload
# fi
Copy link
Member Author

@aMahanna aMahanna Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading coverage to coveralls won't be possible until we request access from the Organization Admin:

image

Will figure out who that is..

Comment on lines +55 to +58
# TODO: Reconsider using a docker image instead of a machine
# i.e cimg/python:<< parameters.python_version >>
machine:
image: ubuntu-2204:current
Copy link
Member Author

@aMahanna aMahanna Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we can revisit using cimg/python with starter.sh as that would cut the job times from ~4 minutes to ~2 minutes.

We currently rely on ubuntu-2204 in combination with pyenv, which is a ~2min bottleneck:

https://github.com/ArangoDB-Community/python-arango/blob/eb8ce582e7b36acf71a51f1de43220c84842e133/.circleci/config.yml#L71-L77

Comment on lines +13 to +14
# TODO: Revisit why pyenv doesn't recognize 3.12
python_version: ["3.8", "3.9", "3.10", "3.11"] # "3.12"
Copy link
Member Author

@aMahanna aMahanna Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason pyenv 2.3.37 does not recognize 3.12 when attempting to do pyenv install 3.12...

However, pyenv install 3.12 worked fine locally with pyenv 2.3.31 🤔

will revisit

Comment on lines +13 to +15
jobs:
# This has been migrated to CircleCI
# test:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving the test job as a reference should we ever need to move back to testing on Github Actions

Average job time here is ~1-2 minutes, but the disadvantage is that we lose access to CircleCI's built-in analytics dashboards

# TODO: Revisit why pyenv doesn't recognize 3.12
python_version: ["3.8", "3.9", "3.10", "3.11"] # "3.12"
arangodb_config: ["single", "cluster"]
arangodb_license: ["community", "enterprise"]
Copy link
Member Author

@aMahanna aMahanna Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to clarify - according to the current state of starter.sh:

community --> docker/arangodb (https://hub.docker.com/r/arangodb/arangodb/tags)
enterprise --> docker/enterprise (https://hub.docker.com/r/arangodb/enterprise/tags)

Perhaps we can revisit the idea of community-preview (https://hub.docker.com/r/arangodb/arangodb-preview/tags) and enterprise-preview (https://hub.docker.com/r/arangodb/enterprise-preview/tags)

@aMahanna aMahanna requested a review from apetenchea November 13, 2023 02:01
@aMahanna aMahanna changed the title do not merge: Experimental CI changes Experimental CI changes Nov 13, 2023
Copy link
Member

@apetenchea apetenchea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apetenchea apetenchea merged commit 3c26c47 into circleci-project-setup Nov 17, 2023
1 check passed
@apetenchea apetenchea deleted the ci-updates-aMahanna branch November 17, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants