-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental CI changes #294
Conversation
# - run: | ||
# name: Upload to Coveralls | ||
# command: | | ||
# if [ "<< parameters.python_version >>" = "3.11" && "<< parameters.arangodb_config >>" = "single" && "<< parameters.arangodb_license >>" = "community" && "<< parameters.arangodb_version >>" = "latest" ]; then | ||
# coveralls/upload | ||
# fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# TODO: Reconsider using a docker image instead of a machine | ||
# i.e cimg/python:<< parameters.python_version >> | ||
machine: | ||
image: ubuntu-2204:current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully we can revisit using cimg/python
with starter.sh
as that would cut the job times from ~4 minutes to ~2 minutes.
We currently rely on ubuntu-2204
in combination with pyenv
, which is a ~2min bottleneck:
# TODO: Revisit why pyenv doesn't recognize 3.12 | ||
python_version: ["3.8", "3.9", "3.10", "3.11"] # "3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason pyenv 2.3.37
does not recognize 3.12
when attempting to do pyenv install 3.12
...
However, pyenv install 3.12
worked fine locally with pyenv 2.3.31
🤔
will revisit
jobs: | ||
# This has been migrated to CircleCI | ||
# test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving the test
job as a reference should we ever need to move back to testing on Github Actions
Average job time here is ~1-2 minutes, but the disadvantage is that we lose access to CircleCI's built-in analytics dashboards
# TODO: Revisit why pyenv doesn't recognize 3.12 | ||
python_version: ["3.8", "3.9", "3.10", "3.11"] # "3.12" | ||
arangodb_config: ["single", "cluster"] | ||
arangodb_license: ["community", "enterprise"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to clarify - according to the current state of starter.sh
:
community
--> docker/arangodb
(https://hub.docker.com/r/arangodb/arangodb/tags)
enterprise
--> docker/enterprise
(https://hub.docker.com/r/arangodb/enterprise/tags)
Perhaps we can revisit the idea of community-preview
(https://hub.docker.com/r/arangodb/arangodb-preview/tags) and enterprise-preview
(https://hub.docker.com/r/arangodb/enterprise-preview/tags)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Branched from #291
Experimenting with Github Actions & CircleCI to make use of matrices to cover a variety of testing environments
.circleci/config.yml
build.yaml
todocs.yaml
starter.sh