Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Add tests for view function and txn simulation filters #11796

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

banool
Copy link
Contributor

@banool banool commented Jan 26, 2024

Description

Before we roll out the feature to prod we should have tests confirming the filtering works and that it doesn't regress. This PR adds those tests.

Related to #11666 and #11714.

Test Plan

cargo test -p aptos-api

Copy link

trunk-io bot commented Jan 26, 2024

⏱️ 5h 37m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-smoke-tests 1h 21m 🟥🟩
windows-build 1h 10m 🟩🟩🟩
rust-unit-tests 38m 🟩
forge-e2e-test / forge 27m 🟥🟩
execution-performance / single-node-performance 21m 🟩
rust-lints 20m 🟩
run-tests-main-branch 15m 🟥🟥🟥🟥
forge-compat-test / forge 14m 🟩
rust-images / rust-all 13m 🟩
check 12m 🟩🟩
general-lints 8m 🟩🟩🟩
check-dynamic-deps 7m 🟩🟩🟩
cli-e2e-tests / run-cli-tests 7m 🟩
semgrep/ci 1m 🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 55s 🟩
file_change_determinator 45s 🟩🟩🟩🟩
file_change_determinator 31s 🟩🟩🟩
permission-check 14s 🟩🟩🟩🟩
permission-check 14s 🟩🟩🟩🟩
permission-check 13s 🟩🟩🟩🟩
file_change_determinator 9s 🟩
execution-performance / parallel-execution-performance 9s 🟩
execution-performance / file_change_determinator 8s 🟩
permission-check 8s 🟩🟩🟩🟩
execution-performance / sequential-execution-performance 7s 🟩
permission-check 2s 🟩
determine-docker-build-metadata 1s 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-lints 12m 8m +48%
rust-images / rust-all 13m 10m +26%

settingsfeedbackdocs ⋅ learn more about trunk.io

@banool banool marked this pull request as ready for review January 26, 2024 18:00
@banool banool enabled auto-merge (squash) January 26, 2024 18:05

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.8.3 ==> d77cd971eac29431b01cf67ec188c3fc733667b2

Compatibility test results for aptos-node-v1.8.3 ==> d77cd971eac29431b01cf67ec188c3fc733667b2 (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 5230 txn/s, latency: 6225 ms, (p50: 5100 ms, p90: 9500 ms, p99: 19900 ms), latency samples: 193520
2. Upgrading first Validator to new version: d77cd971eac29431b01cf67ec188c3fc733667b2
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1774 txn/s, latency: 15747 ms, (p50: 19000 ms, p90: 21800 ms, p99: 22500 ms), latency samples: 92260
3. Upgrading rest of first batch to new version: d77cd971eac29431b01cf67ec188c3fc733667b2
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1784 txn/s, latency: 16125 ms, (p50: 19000 ms, p90: 22000 ms, p99: 22300 ms), latency samples: 92800
4. upgrading second batch to new version: d77cd971eac29431b01cf67ec188c3fc733667b2
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2768 txn/s, latency: 9434 ms, (p50: 9900 ms, p90: 14100 ms, p99: 15800 ms), latency samples: 135660
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> d77cd971eac29431b01cf67ec188c3fc733667b2 passed
Test Ok

Copy link
Contributor

@bchocho bchocho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on d77cd971eac29431b01cf67ec188c3fc733667b2

two traffics test: inner traffic : committed: 7105 txn/s, submitted: 7106 txn/s, latency: 5351 ms, (p50: 4800 ms, p90: 6900 ms, p99: 12700 ms), latency samples: 3076858
two traffics test : committed: 100 txn/s, latency: 2328 ms, (p50: 2200 ms, p90: 2500 ms, p99: 6800 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.222, avg: 0.200", "QsPosToProposal: max: 0.159, avg: 0.147", "ConsensusProposalToOrdered: max: 0.587, avg: 0.533", "ConsensusOrderedToCommit: max: 0.547, avg: 0.501", "ConsensusProposalToCommit: max: 1.074, avg: 1.033"]
Max round gap was 1 [limit 4] at version 1384752. Max no progress secs was 7.045172 [limit 10] at version 1384752.
Test Ok

@banool banool merged commit d8127d6 into main Jan 26, 2024
82 of 84 checks passed
@banool banool deleted the banool/view-filter-tests branch January 26, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants