-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick bc4b3fcd449f3376f9e891245d9fb31e11016c13 into aptos-release-v1.9 #11714
Cherry pick bc4b3fcd449f3376f9e891245d9fb31e11016c13 into aptos-release-v1.9 #11714
Conversation
⏱️ 4m total CI duration on this PR
|
I see it’s being manually tested, but can we add some unit test case there to cover the functionality? I don’t expect we’re using this feature frequently in production, and we need to make sure it works when we need it. Also we'd need to document how to use it so that during emergency people can actually apply the config change. |
PR to add tests: #11796. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
❌ Forge suite
|
Context: https://aptos-org.slack.com/archives/C06BBLE5AHK.