Release 2.21.0 #4922
Release 2.21.0 #4922
Conversation
This fork is identical to [email protected] except that it allows graphql@15 as a peer dependency (and bundles the TypeScript type definitions directly). For #4865. Note that we do plan to remove this integration in Apollo Server 3, but for now we want you to be able to combine AS2 with graphql@15 and npm@7.
|
This release only has one change (edit: see below, there's one other tiny deps change too): replacing the I published an Trying to install Trying to install The deprecation messages are specific to apollo-server-hapi and apollo-server-micro and are not displayed if you don't install those particular integrations. (Note: we will not be doing further feature development in this fork. It's just to fix the peer dependency, not to try to take over development from @jaydenseric! Additionally, we are still planning to drop the built-in upload integration from Apollo Server 3. We encourage folks who want to use I'd love to get some reports from users (especially those who actually use the graphql-upload integration!) that these alphas work for you before I release. So if you can install |
| @@ -55,6 +55,7 @@ | |||
| "graphql-extensions": "file:packages/graphql-extensions" | |||
| }, | |||
| "devDependencies": { | |||
| "@apollographql/graphql-upload-8-fork": "^8.1.3", | |||
There was a problem hiding this comment.
I did this to make it visible to a build-time-only import type in apollo-server-fastify (I think that's the right way to do it?).
|
Hmm, I think I should also resolve #3954 in this release. |
That's the version that's required for graphql@15 support. Let's make things smoother by helping people get it installed even if they have an old package-lock with 4.0.0 in it. Fixes #3954.
|
I published v2.21.0-alpha.2 which also bumps the dependency on graphql-tools from 4.0.0 to 4.0.8, for graphql@15 compatibility. (This mostly matters for folks with old projects who are upgrading.) Most people have probably already been running against 4.0.8 for nearly a year. |
| @@ -5560,7 +5587,7 @@ | |||
| "requires": { | |||
| "@apollographql/apollo-tools": "^0.4.3", | |||
| "@apollographql/graphql-playground-html": "1.6.26", | |||
| "@types/graphql-upload": "^8.0.0", | |||
There was a problem hiding this comment.
Nice, thanks for adding this note in the fork's README, I was unsure about this change.
https://github.com/apollographql/graphql-upload#readme
This fork also contains the TypeScript typings from DefinitelyTyped, so you don't have to try to combine this fork with @types/graphql-upload
There was a problem hiding this comment.
Yeah, the alternative seemed pretty challenging to me (some weird tsconfig hacking...)
| @@ -11,7 +11,7 @@ import { | |||
| import { FastifyInstance, FastifyReply, FastifyRequest } from 'fastify'; | |||
| import { IncomingMessage, OutgoingMessage, ServerResponse, Server } from 'http'; | |||
| import { graphqlFastify } from './fastifyApollo'; | |||
| import { GraphQLOperation } from 'graphql-upload'; | |||
| import type { GraphQLOperation } from '@apollographql/graphql-upload-8-fork'; | |||
There was a problem hiding this comment.
Pretty sure what you've done here and the corresponding change in package.json is correct, though I'm having a hard time saying with certainty. Just noting since you also had a question about it and I don't want to say "yes" without saying "I'm not totally sure".
There was a problem hiding this comment.
Well two people at "pretty sure" equals a "totally sure", right?
|
I'd love to hear a positive experience with this alpha from somebody who had trouble with peer dependencies before; otherwise this is ready to ship! Note that I'm on vacation next week, so hopefully we can get this out tomorrow. |
|
Output on running When running |
|
Great, one positive experience is good for me (especially for a release with no code changes). Publishing! |
As with release PRs in the past, this is a PR tracking a
release-x.y.zbranch for an upcoming release of Apollo Server. 🙌 The version in the title of this PR should correspond to the appropriate branch.Check the appropriate milestone (to the right) for more details on what we hope to get into this release!
The intention of these release branches is to gather changes which are intended to land in a specific version (again, indicated by the subject of this PR). Release branches allow additional clarity into what is being staged, provide a forum for comments from the community pertaining to the release's stability, and to facilitate the creation of pre-releases (e.g.
alpha,beta,rc) without affecting themainbranch.PRs for new features might be opened against or re-targeted to this branch by the project maintainers. The
mainbranch may be periodically merged into this branch up until the point in time that this branch is being prepared for release. Depending on the size of the release, this may be once it reaches RC (release candidate) stage with an-rc.xrelease suffix. Some less substantial releases may be short-lived and may never have pre-release versions.When this version is officially released onto the
latestnpm tag, this PR will be merged intomain.