Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-server-core has a hardcoded dependency on graphql 14.7.0 #4413

Closed
2 tasks
mschipperheyn opened this issue Jul 24, 2020 · 7 comments
Closed
2 tasks

apollo-server-core has a hardcoded dependency on graphql 14.7.0 #4413

mschipperheyn opened this issue Jul 24, 2020 · 7 comments

Comments

@mschipperheyn
Copy link

Apollo server core depends on 14.7.0, whereas apollo-server-express has a peerdependency permitting 15.0.0.
This can create problems in monorepos and is for me. I can prob work around it, but the @types/graphql-upload is already a year old. It should prob be updated to 8.0.3

Versions
apollo-server-express: 16.0

Expected
depend on graphql 15 and allow resolving to that version

Actual
Resolving to graphql 15.x results in a build error with yarn install --frozen-lockfile

This bug report should include:

  • [x ] A short, but descriptive title. The title doesn't need "Apollo" in it.

  • [ x] The package name and version of Apollo showing the problem.

  • If applicable, the last version of Apollo where the problem did not occur.

  • [ x] The expected behavior.

  • [ x] The actual behavior.

  • A simple, runnable reproduction!
    Please make a GitHub repository that anyone can clone and run and see the
    problem. Other great ways to demonstrate a reproduction are using our
    CodeSandbox template (https://codesandbox.io/s/apollo-server), or re-mixing
    our Glitch template (https://glitch.com/~apollo-launchpad).

    Please make sure that you include the following information to ensure that your issue is actionable.

    If you don't follow the template, your issue may end up being closed without anyone looking at it carefully, because it is not actionable for us without the information in this template.

-->

@mschipperheyn
Copy link
Author

mschipperheyn commented Aug 3, 2020

should be upgraded to

graphql-upload 11.0.0
@types/graphql-upload 8.0.3

to fix this. Ah shit. @types/graphql-upload is outdated

@tvvignesh
Copy link

Yup. Looks like the version of graphql-upload package is 11.0.0 and it supports graphql 15.x but apollo-server-core uses 8.0.2 (https://github.com/apollographql/apollo-server/blob/main/packages/apollo-server-core/package.json) May need an upgrade.

Screenshot 2020-08-29 142505

CC: @abernix

@lewebsimple
Copy link

Any update on this ?

@bigman73
Copy link

any update of this?

@Shawnxkwang
Copy link

any update?? This is a serious issue

@tal130
Copy link

tal130 commented Dec 27, 2020

Any update on this? I saw there was new release but it still not resolve

@abernix
Copy link
Member

abernix commented Mar 4, 2021

I believe this was fixed by c871152 in #4922, and released in Apollo Server 2.21.0. Please report back if this is not the case!

@abernix abernix closed this as completed Mar 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants