Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chain-support.json validation #208

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Add chain-support.json validation #208

merged 5 commits into from
Sep 25, 2024

Conversation

dcroote
Copy link

@dcroote dcroote commented Sep 22, 2024

Closes #207

@dcroote dcroote self-assigned this Sep 22, 2024
bbenligiray
bbenligiray approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@bbenligiray bbenligiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the implementation looks good. However, it feels like this can be done as a part of validate-deployment-config?

@dcroote
Copy link
Author

dcroote commented Sep 24, 2024

However, it feels like this can be done as a part of validate-deployment-config?

Agreed this makes more sense; I've updated the PR accordingly

bbenligiray
bbenligiray approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@bbenligiray bbenligiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bbenligiray bbenligiray merged commit a5cf7a2 into main Sep 25, 2024
4 checks passed
@bbenligiray bbenligiray deleted the chain-support-validation branch September 25, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbenligiray bbenligiray bbenligiray approved these changes

Assignees

@dcroote dcroote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate chain-support.json for alphabetical order and duplicates
2 participants
@dcroote @bbenligiray