Merge pull request #208 from api3dao/chain-support-validation

Add chain-support.json validation
api3dao · Sep 25, 2024 · a5cf7a2 · a5cf7a2
2 parents 5b2ebb7 + 0a84ae6
commit a5cf7a2
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 12 deletions.
diff --git a/data/chain-support.json b/data/chain-support.json
@@ -19,7 +19,6 @@
     "bsc",
     "bsc-testnet",
     "bsquared",
-    "blast-sepolia-testnet",
     "camp-sepolia-testnet",
     "conflux",
     "conflux-testnet",
@@ -77,10 +76,10 @@
     "rari",
     "rari-arbitrum-sepolia-testnet",
     "rsk",
-    "sei",
-    "sei-testnet",
     "scroll",
     "scroll-sepolia-testnet",
+    "sei",
+    "sei-testnet",
     "soneium-sepolia-testnet",
     "sonic-testnet",
     "taiko",
@@ -166,10 +165,10 @@
     "polygon-zkevm-sepolia-testnet",
     "rari",
     "rari-arbitrum-sepolia-testnet",
-    "sei",
-    "sei-testnet",
     "scroll",
     "scroll-sepolia-testnet",
+    "sei",
+    "sei-testnet",
     "soneium-sepolia-testnet",
     "sonic-testnet",
     "taiko",

diff --git a/data/manager-multisig.json b/data/manager-multisig.json
@@ -41,14 +41,14 @@
   "kroma-sepolia-testnet": "0x14A9E40FcAdA95A273ce3c8d4ccF7EA3280BDd26",
   "lightlink": "0x14A9E40FcAdA95A273ce3c8d4ccF7EA3280BDd26",
   "lightlink-sepolia-testnet": "0x5aB00E30453EEAd35025A761ED65d51d74574C24",
-  "manta": "0x0D4136b033807C5298a77E2ad7ebE8ce05207D2d",
-  "manta-sepolia-testnet": "0x29AbCeDfa34a229536962b3061913842F103A916",
   "linea": "0x14A9E40FcAdA95A273ce3c8d4ccF7EA3280BDd26",
   "linea-sepolia-testnet": "0x14A9E40FcAdA95A273ce3c8d4ccF7EA3280BDd26",
   "lukso": "0x14A9E40FcAdA95A273ce3c8d4ccF7EA3280BDd26",
   "lukso-testnet": "0x14A9E40FcAdA95A273ce3c8d4ccF7EA3280BDd26",
   "lumia": "0x026A473DAB17ef658Ca09d726c70b4570A76188b",
   "lumia-sepolia-testnet": "0x026A473DAB17ef658Ca09d726c70b4570A76188b",
+  "manta": "0x0D4136b033807C5298a77E2ad7ebE8ce05207D2d",
+  "manta-sepolia-testnet": "0x29AbCeDfa34a229536962b3061913842F103A916",
   "mantle": "0x14A9E40FcAdA95A273ce3c8d4ccF7EA3280BDd26",
   "mantle-sepolia-testnet": "0x25C6f371Cf8d4200B89dF84f9dE69d011013B086",
   "merlin": "0x14A9E40FcAdA95A273ce3c8d4ccF7EA3280BDd26",

diff --git a/scripts/validate-deployment-config.ts b/scripts/validate-deployment-config.ts
@@ -10,18 +10,28 @@ import managerMultisigAddresses from '../data/manager-multisig.json';
 
 function main() {
   const chainAliases = new Set(CHAINS.map((chain) => chain.alias));
-  [
-    Object.keys(managerMultisigAddresses),
+  const records: Record<string, string[]> = {
+    managerMultisigAddresses: Object.keys(managerMultisigAddresses),
     chainsSupportedByDapis,
     chainsSupportedByMarket,
     chainsSupportedByOevAuctions,
-  ].map((supportedChainAliases) => {
-    supportedChainAliases.map((supportedChainAlias) => {
+  };
+
+  Object.entries(records).forEach(([fieldName, supportedChainAliases]) => {
+    supportedChainAliases.forEach((supportedChainAlias) => {
       if (!chainAliases.has(supportedChainAlias)) {
-        throw new Error(`Supported chain with alias ${supportedChainAlias} does not exist`);
+        throw new Error(`Supported chain in ${fieldName} with alias ${supportedChainAlias} does not exist`);
       }
     });
+    if (new Set(supportedChainAliases).size !== supportedChainAliases.length) {
+      throw new Error(`Duplicates found in ${fieldName}`);
+    }
+    const sortedSupportedChainAliases = [...supportedChainAliases].sort();
+    if (JSON.stringify(supportedChainAliases) !== JSON.stringify(sortedSupportedChainAliases)) {
+      throw new Error(`${fieldName} is not sorted`);
+    }
   });
+
   Object.entries(managerMultisigAddresses).map(([alias, address]) => {
     if (!ethers.isAddress(address)) {
       throw new Error(`Manager multisig address of ${alias}, ${address as string}, is not valid`);