Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deviationThresholdCoefficient config field #20

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

vponline
Copy link
Contributor

@vponline vponline commented Oct 4, 2023

Closes #14

I suspected we might also make this value an integer, but wasn't sure if we might have use for fractions for some reason

getting started with an easy one 😄

@vponline vponline requested a review from aquarat October 4, 2023 12:46
Copy link
Collaborator

@aquarat aquarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No judgement from me 😝
Only question from me is, is this a base 1 multiplier? so a secondary Airseeker would be 2 for x2 the thresholds? It'd probably be useful to have the ability to set a float for this (which .number allows).

Something else that may not have been considered: the current Airseeker config generators also allow for the heartbeat interval to have a margin added to it for secondary deployments - otherwise different Airseekers every HR interval on low volatility feeds try to execute updates at the same time.

@vponline
Copy link
Contributor Author

vponline commented Oct 5, 2023

Only question from me is, is this a base 1 multiplier? so a secondary Airseeker would be 2 for x2 the thresholds? It'd probably be useful to have the ability to set a float for this (which .number allows).

Yes this is exactly how I understood the purpose of this field

@vponline vponline merged commit c356371 into main Oct 5, 2023
3 checks passed
@bbenligiray
Copy link
Member

I'd say make this optional with a default value of 1

@Siegrift Siegrift deleted the add-deviation-threshold-coefficient branch November 22, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add global deviationThresholdCoefficient config
3 participants