Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create data feed update loop #37

Merged
merged 9 commits into from
Oct 27, 2023
Merged

Create data feed update loop #37

merged 9 commits into from
Oct 27, 2023

Conversation

Siegrift
Copy link
Collaborator

Closes #34

@Siegrift Siegrift self-assigned this Oct 23, 2023
Base automatically changed from add-logger to main October 25, 2023 08:31
@Siegrift Siegrift changed the title WIP: Create data feed update loop Create data feed update loop Oct 25, 2023
@Siegrift Siegrift force-pushed the create-data-feed-update-loop branch 3 times, most recently from 0b925f9 to 42d5620 Compare October 26, 2023 10:01
@Siegrift
Copy link
Collaborator Author

I reworked how the configuration files work because the old approach (using the project field) did not support running only some tests with the following: pnpm run test schema (runs only files containing "schema").

vponline
vponline approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@vponline vponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, only a couple minor notes that are mostly preference anyway 🏅

src/config/schema.ts Outdated Show resolved Hide resolved
src/update-feeds/update-feeds.ts Outdated Show resolved Hide resolved
src/update-feeds/update-feeds.ts Show resolved Hide resolved
@Siegrift Siegrift force-pushed the create-data-feed-update-loop branch 2 times, most recently from 945e289 to dec8cc1 Compare October 27, 2023 12:41
@Siegrift Siegrift merged commit ffe5d3e into main Oct 27, 2023
4 checks passed
@Siegrift Siegrift deleted the create-data-feed-update-loop branch October 27, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vponline vponline vponline approved these changes

@aquarat aquarat Awaiting requested review from aquarat

Assignees

@Siegrift Siegrift

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create data feed update loops fetching batches of mocked chain data
2 participants
@Siegrift @vponline