Issue #382: Warning when PEAR contains a JCAS class that is used as a feature range outside the PEAR #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature range outside the PEAR - Added a "test" which reproduces the warning although there is no assert that checks if the warning is logged - Some cleaning up
… feature range outside the PEAR - Improved tests - The test still does not fail because there is warning though...
… feature range outside the PEAR - Do not issue warning on range mismatch if range class was loaded from a PEAR classloader - Clean up
|
Jenkins, can you test this please? |
reckart
force-pushed
the
bugfix/382-Warning-when-PEAR-contains-a-JCAS-class-that-is-used-as-a-feature-range-outside-the-PEAR
branch
from
2a42834
to
2be2168
Compare
… feature range outside the PEAR - Make sure tests close files so temporary test folders can be deleted
reckart
force-pushed
the
bugfix/382-Warning-when-PEAR-contains-a-JCAS-class-that-is-used-as-a-feature-range-outside-the-PEAR
branch
from
2be2168
to
f95a3a4
Compare
…ns-a-JCAS-class-that-is-used-as-a-feature-range-outside-the-PEAR * release/3.5.x: Issue #371: Repeated creation of type systems can exhaust JVM metaspace Issue #371: Repeated creation of type systems can exhaust JVM metaspace % Conflicts: % uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java
reckart
deleted the
bugfix/382-Warning-when-PEAR-contains-a-JCAS-class-that-is-used-as-a-feature-range-outside-the-PEAR
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation
Organizational
Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.
Let's assume we have:
Xwith a featureX.aof typeAX1that is a subtype ofXOk, so what can happen...
X,AX,AX.setA(A)X,AAcas.createFS('X').setFeatureValue('a', 'A'); The rule is that the PEARs must embed all classes they uses at compile time - ergo - the PEAR cannot useX.getA()orX.setA()because it does not embed X.X,A,X1Xcas.select(X.class)but will get aClassCastExceptionwhen it encounters aX1- see #384