[MNG-8041] A quick draft about problem #1398
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
reviewed
Feb 5, 2024
| Collection<String> resolveScopesToExclude = negate(scopesToResolve); | ||
|
|
||
| DependencyFilter collectionFilter = new ScopeDependencyFilter(null, collectScopesToExclude); | ||
| DependencyFilter resolutionFilter = new ScopeDependencyFilter(null, resolveScopesToExclude); |
There was a problem hiding this comment.
can we just use the scopes to collect / resolve instead of the ones to exclude and give them as a negative test in the filter ?
i.e.:
DependencyFilter collectionFilter = new ScopeDependencyFilter(scopesToCollect);
DependencyFilter resolutionFilter = new ScopeDependencyFilter(scopesToResolve);
# Conflicts: # maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a attempt to fix reproducer, and to see what ITs have to say.
https://github.com/cstamas/MNG-8041 is a reproducer: when asked
mvn provisio:provisionthe lib will lack guava, while it should be part of runtime dependency (and actually IS, when the project is used as dependency!).https://issues.apache.org/jira/browse/MNG-8041